Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ap-southeast-5 region #517

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Sep 27, 2024

What does this PR do?

  • Updates our pipeline
  • Adds ap-southeast-5 to regions to deploy

Motivation

DataDog/datadog-lambda-js#576

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista requested a review from a team as a code owner September 27, 2024 18:46
Copy link
Contributor

@apiarian-datadog apiarian-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this all of the regions that exist? or all minus some set of explicitly unsupported ones? should we query them instead of listing them manually?

@duncanista
Copy link
Contributor Author

is this all of the regions that exist? or all minus some set of explicitly unsupported ones? should we query them instead of listing them manually?

Yes,
No,
The query only returns the ones available in your region, therefore, this would require us to have multiple steps to verify them. This is OK, as is our best current solution.

@duncanista
Copy link
Contributor Author

duncanista commented Oct 1, 2024

Screenshot 2024-10-01 at 5 57 22 PM
Tested manually in GitLab, this works.

@duncanista duncanista merged commit 10da76b into main Oct 1, 2024
51 checks passed
@duncanista duncanista deleted the jordan.gonzalez/gitlab/add-ap-southeast-5 branch October 1, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants