Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dynamic libdd_wrapper.so filename #516

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

brettlangdon
Copy link
Member

What does this PR do?

DataDog/dd-trace-py#10840 is changing the name of the libdd_wrapper.so file, we need to update this Dockerfile to support the change in the name.

Motivation

Without this change, after the release of DataDog/dd-trace-py#10840 the building of this Dockerfile will start to fail.

Testing Guidelines

This was caught in the serverless benchmark job failing with this change.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@brettlangdon brettlangdon requested a review from a team as a code owner September 27, 2024 17:49
@brettlangdon brettlangdon merged commit adfc9e8 into main Sep 27, 2024
51 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/libdd_wrapper branch September 27, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants