Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVLS-4797] safety check before create cold start spans #485

Merged
merged 1 commit into from
May 15, 2024

Conversation

joeyzhao2018
Copy link
Contributor

What does this PR do?

Add a one-liner safety check to skip generating cold start spans when the trace context is broken. (Because we have seen this) to avoid creating each cold start tracing node a new trace.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner May 14, 2024 20:29
@purple4reina
Copy link
Contributor

Just curious, under what circumstances is the trace context not getting set?

@joeyzhao2018
Copy link
Contributor Author

Just curious, under what circumstances is the trace context not getting set?

Good question. This issue in dd-trace-py was causing trace context resetting for example. This could also happen if customers' code has reset the trace context for any unknown reasons

@joeyzhao2018 joeyzhao2018 merged commit 87adb4d into main May 15, 2024
51 checks passed
@joeyzhao2018 joeyzhao2018 deleted the joey/safety-check branch May 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants