Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ddsaml2aws login from release script #484

Merged

Conversation

TalUsvyatsky
Copy link
Contributor

What does this PR do?

This PR removes the ddsaml2aws login from the publish prod script.

Motivation

Govcloud access has been fully migrated to use SSO.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@TalUsvyatsky TalUsvyatsky marked this pull request as ready for review May 2, 2024 13:20
@TalUsvyatsky TalUsvyatsky requested a review from a team as a code owner May 2, 2024 13:20
@TalUsvyatsky TalUsvyatsky merged commit 95dd5be into main May 2, 2024
51 checks passed
@TalUsvyatsky TalUsvyatsky deleted the tal.usvyatsky/remove-ddsaml2aws-from-release-script branch May 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants