Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Use dd-trace-py 0.61.1 #227

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

adamantike
Copy link
Contributor

What does this PR do?

Upgrade ddtrace dependency to the latest available 0.x version at the moment.

Motivation

While debugging why a Lambda function wasn't creating spans for aiohttp clients, it was found that the aiohttp client integration was added in dd-trace-py 0.60.0. This is a required change for Lambda functions that rely on datadog-lambda to correctly trace aiohttp.

Testing Guidelines

  • Unit tests provided by ./scripts/run_tests.sh pass.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Upgrade `ddtrace` dependency to the latest available `0.x` version at
the moment.
@adamantike adamantike requested a review from a team as a code owner June 20, 2022 01:41
@adamantike
Copy link
Contributor Author

Integration tests have failed with error:

Python version is specified: 3.9
No AWS credentials were found in the environment.
Note that only Datadog employees can run these integration tests.
Error: Process completed with exit code 1.

Should the CI be triggered in a special way to have a clean run?

@astuyve
Copy link
Contributor

astuyve commented Jun 21, 2022

Hey @adamantike - that's fine, credentials are only injected for branches ran from Datadog developers. We can run them manually. This PR looks good, thanks for the contribution! I'll merge and release after I finish a few other tasks.

@astuyve astuyve merged commit e4f6678 into DataDog:main Jun 22, 2022
@adamantike
Copy link
Contributor Author

Thanks for the quick merge, @astuyve! Looking forward for a new release to start using it.

@adamantike adamantike deleted the misc/ddtrace-0.61.1 branch June 22, 2022 14:34
@astuyve
Copy link
Contributor

astuyve commented Jun 22, 2022

No problem! The release is rolling out now. It'll be available in v3.59.0, and layer version 59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants