Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLS-2141] Fix keyError issue when creating inferred span #223

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

hghotra
Copy link
Contributor

@hghotra hghotra commented Apr 8, 2022

What does this PR do?

Currently, when creating an inferred span, we use the [] syntax to access keys within the event payload. Switching this to .get(key) will make sure there is no keyError and the tag is simply ignored.

Motivation

Customer reported issue with creating API Gateway inferred span when apiid is not defined in the request context.

Testing Guidelines

Unit test & integration test.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@hghotra hghotra requested a review from a team as a code owner April 8, 2022 21:04
Copy link
Contributor

@jcstorms1 jcstorms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hghotra hghotra merged commit 07a0ce0 into main Apr 12, 2022
@hghotra hghotra deleted the hsg/sls-2141-missing-tags-fix branch April 12, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants