Add an API to send multiple samples at once #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Dec 14, 2023
vickenty
previously approved these changes
Dec 14, 2023
Co-authored-by: Olivier Vielpeau <[email protected]>
remeh
approved these changes
Dec 15, 2023
blemale
added a commit
to blemale/java-dogstatsd-client
that referenced
this pull request
Jan 26, 2024
recordDistributionValues is similar to recordDistributionValue but it lets the client sends multiple samples in one message using dogstatsd 1.1 protocol. Because this is a shift compared to how other methods are behaving, these methods are provided only in DirectStatsDClient which provides direct access to some low level dogstatsd protocol features. This is recommended in high performance cases were the overhead of the statsd library might be significant and the sampling is already done by the client. Port of DataDog/datadog-go#296.
blemale
added a commit
to blemale/java-dogstatsd-client
that referenced
this pull request
Jan 26, 2024
recordDistributionValues is similar to recordDistributionValue but it lets the client sends multiple samples in one message using dogstatsd 1.1 protocol. Because this is a shift compared to how other methods are behaving, these methods are provided only in DirectStatsDClient which provides direct access to some low level dogstatsd protocol features. This is recommended in high performance cases were the overhead of the statsd library might be significant and the sampling is already done by the client. Port of DataDog/datadog-go#296.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DistributionSamples is similar to Distribution, but it lets the client deals with the sampling, rate is passed to the agent and not used for further sampling. WithMaxBufferedMetricsPerContext is ignored when using this method.
Because this is a shift compared to how other methods are behaving, this method is provided only in ClientDirect which provides direct access to some low level dogstatsd protocol features like DataDog/datadog-go#extended-aggregation
This is recommended in high performance cases were the overhead of the statsd library might be significant and the sampling is already done by the client.
NewDirectandNewDirectWithWritercan be used to instantiate a new direct client, mocks and noop clients are available.replaces #292