Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, version v5 of the library cannot be used on Windows, let's try
ends
This PR fixes it, by
import io
(change has been already proposed by Fix missing import #241, thanks @evanj)newUDSWriter
for WindowsIn the future could you add CI testing on Windows too? It'll allow catching quickly such things before releases and save your time. Moreover, I recommend including macOS too, even if the library hasn't had this problem. I know that both systems are mostly Unix like and should be compatible, but some differences may exist (e.g. I stumbled in my project on the fact that Linux has syscall gettid and macOS doesn't). Errors may appear in the future so it's better to be extra cautious.