Detect address from env before resolving it #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR @hoshsadiq. I opened #192 to answer the issue and re-organize the code and tests. |
|
This has been fixed in |
|
Thanks @hush-hush, will test it out before the end of the week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the address is resolved from the environment after it is determined that we're not using unix socket/windows pipe. In our case, the application passes in an empty address, as we're relying on the client to determine the address from the environment. However, if
DD_AGENT_HOSTis set and prefixed withunix://or\\.\pipe\, it won't have detected this and will eventually just falls back toUDPWriter(in this case, it also always adds the default port). This should fix that by retrieving the address from the environment before that logic kicks in.Edit: Not really sure how to test windows. I don't have a windows machine.