Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: NoopClient #88

Closed
srizzling opened this issue May 2, 2019 · 0 comments · Fixed by #92
Closed

Feature Request: NoopClient #88

srizzling opened this issue May 2, 2019 · 0 comments · Fixed by #92

Comments

@srizzling
Copy link

The DataDog Java statsd client provides an interface for a NoopStatsD Client (https://github.com/DataDog/java-dogstatsd-client/blob/master/src/main/java/com/timgroup/statsd/NoOpStatsDClient.java)

This request, is requesting a similar interface to aid with testing. Having a NoopClient, will allow us to stub the client, when we are unit testing our buisness code, and or record statsd to ensure delivery (maybe?).
@asf-stripe asf-stripe mentioned this issue May 29, 2019
Merged
goodspark pushed a commit to goodspark/datadog-go that referenced this issue Sep 10, 2019
Add noop client and tests
584a084 
Resolves DataDog#88
@goodspark goodspark mentioned this issue Sep 10, 2019
Merged
goodspark pushed a commit to goodspark/datadog-go that referenced this issue Oct 22, 2019
Add noop client and tests
f7a0613 
Resolves DataDog#88
@arbll arbll closed this as completed in #92 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a NoOp client goodspark/datadog-go
1 participant
@srizzling