compile script cannot find trace-agent

[laugekj]

Describe the bug
Installing the buildpack with github link in manifest has missing file or directory

To Reproduce
Steps to reproduce the behavior:

1. cf push
2. manifest.yml has:

buildpacks:
  - https://github.com/DataDog/datadog-cloudfoundry-buildpack/
  - nodejs_buildpack 

Produces the following output:

   -----> DatadogBuildpack/supply version 4.40.0
   Installing Datadog IOT Agent, Dogstatsd and Trace Agent
   cp: cannot stat '/tmp/buildpackdownloads/e787c33875b9083b/lib/trace-agent': No such file or directory
   chmod: cannot access '/tmp/app/.datadog/trace-agent': No such file or directory
   ruby version check: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]

Expected behavior
Expected datadog-cloudfoundry-buildpack to be installed on container.

Environment and Versions (please complete the following information):
A clear and precise description of your setup:

• DatadogBuildpack/supply version 4.40.0

Additional context
My hosting architecture does not allow me to run "cf create-buildpack", so I need a work around this binaries not being runnable from github link (see related issue: #7). My hosting architecture will not allow me to create Cloud Foundry Adminstrator for customer accounts, since my Cloud Foundry deployment is in SAP BTP.

[NouemanKHAL]

Hi @laugekj, Thanks for the issue report!

Did you try using a link that ends with .git like git://github.com/DataDog/datadog-cloudfoundry-buildpack.git as mentioned in the custom buildpacks documentation here.

Meanwhile, we'll try to reproduce this on our side and will keep you updated with our findings.

[NouemanKHAL]

Hi again @laugekj ,

Having a second look at the problem, the missing binaries are due to the fact that we don't store the binaries (agent, trace-agent, dogstatsd) in the Git repo. We download them in the prepare script during the release process.

I guess you could try pushing them to a custom branch/fork and see if that works?

[laugekj]

Hi Thanks for the reply. I will try that to see if that works. Best regards Lauge Jensen

…

________________________________ From: NouemanKHAL ***@***.***> Sent: Monday, August 26, 2024 12:06:28 PM To: DataDog/datadog-cloudfoundry-buildpack ***@***.***> Cc: Lauge Kjærgaard Jensen ***@***.***>; Mention ***@***.***> Subject: Re: [DataDog/datadog-cloudfoundry-buildpack] compile script cannot find trace-agent (Issue #191) Hi again @laugekj<https://github.com/laugekj> , Having a second look at the problem, the missing binaries are due to the fact that we don't store the binaries (agent, trace-agent, dogstatsd) in the Git repo. We download them in the prepare script<https://github.com/DataDog/datadog-cloudfoundry-buildpack/blob/master/scripts/prepare.sh> during the release process. I guess you could try pushing them to a custom branch/fork and see if that works? — Reply to this email directly, view it on GitHub<#191 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN2YFZWDEA4BFTETWQZIK2LZTL42JAVCNFSM6AAAAABJNNPXQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZHAZTSNJUGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>