Copying Stack tags to the Datadog monitor (#226) #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudformation supports tags at a stack level. They are normally passed on to all Cloudformation resources (some resources don't support that yet...). Datadog monitors got tags, too. With this change, the Cloudformation Stack tags are copied to the Datadog monitor. Additionally, the AWS autogenerated tags like stack name and logical id are also set. If a tag is already set explicitly at a monitor, the monitor value is being used. Since Datadog uses a : to separate key and value, all : are replaced with _. In order to maintain backwards compatibility, this feature is switched off by default. It can be enabled account-wide via the type configuration, the same way Datadog credentials are being set.
|
Hi, thanks for this PR. After a bit of testing we reverted this change. We realized that systemTags and others are not passed within the request context during the execution of the read_handler. This complicates things a bit further because it is difficult to properly handle resource drift with this implementation. I am going to close this PR however, we are evaluating alternative approaches such as the native |
|
I personally would be happy with the drift, but I can understand if you are not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudformation supports tags at a stack level. They are normally passed on to all Cloudformation resources (some resources don't support that yet...). Datadog monitors got tags, too. With this change, the Cloudformation Stack tags are copied to the Datadog monitor. Additionally, the AWS autogenerated tags like stack name and logical id are also set. If a tag is already set explicitly at a monitor, the monitor value is being used. Since Datadog uses a : to separate key and value, all : are replaced with _.
In order to maintain backwards compatibility, this feature is switched off by default. It can be enabled account-wide via the type configuration, the same way Datadog credentials are being set.
Requirements for Contributing to this repository
What does this PR do?
This PR fixes #226
Description of the Change
See commit message
Alternate Designs
No alternate design.
Possible Drawbacks
There should be none, since the feature is implemented in a backwards-compatible way.
Verification Process
Additional Notes
I didn't add a test because there were none and I didn't work with python cloudformation resources before.
Release Notes
Copying Stack tags to the Datadog monitor (disabled by default)
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.