Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDTEST-1304] Fix inline comments handling when parsing CODEOWNERS files #267

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[SDTEST-1304] Fix inline comments handling when parsing CODEOWNERS files #267

merged 1 commit into from
Dec 9, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?

Fixes a bug with handling of inline comments in CODEOWNERS:

/path/to/file.rb @owner1 @owner2 #This is an inline comment.

Before this fix it produced the following list of owners:

["@owner1", "@owner2", "#This", "is", "an", "inline", "comment."]

After the fix:

["@owner1", "@owner2"]

How to test the change?
Unit tests

@anmarchenko anmarchenko requested review from a team as code owners December 9, 2024 10:43
@anmarchenko anmarchenko merged commit fc3e0d1 into main Dec 9, 2024
170 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/codeowners_parsing_bug branch December 9, 2024 11:17
@github-actions github-actions bot added this to the 1.11.0 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@y9v y9v y9v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anmarchenko @y9v @nikita-tkachenko-datadog