[SDTEST-1129] Extract Knapsack instrumentation as standalone integration #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logic from Settings
…ename auto_instrument method to late_instrument
anmarchenko
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 98.73% 98.77% +0.04%
==========================================
Files 293 291 -2
Lines 13961 13933 -28
Branches 668 670 +2
==========================================
- Hits 13784 13762 -22
+ Misses 177 171 -6 ☔ View full report in Codecov by Sentry. |
y9v
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors Contrib module and extracts Knapsack instrumentation as a standalone integration (rather than putting knapsack instrumentation inside rspec).
I used this work also as a chance to make instrumentation code more object oriented and untangle the complex mix of class-level and object-level methods that was inherited from Tracing implementation.
Motivation
For the auto-instrumentation feature we need to instrument every gem as a separate integration.
How to test the change?
No changes in the behaviour, covered by existing unit tests.