[SDTEST-1129] Internal: decouple patcher from tracing, update ruby 3.4 compatibility #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
changed the title
anmarchenko
changed the title
Strech
approved these changes
Nov 6, 2024
|
|
||
| def on_patch_error: (untyped e) -> untyped | ||
|
|
||
| def default_tags: () -> untyped |
There was a problem hiding this comment.
I know that it might be cumbersome to fill in, but maybe we can shape it a bit? Like if it's Array, we can state it?
There was a problem hiding this comment.
Hopefully, while building auto instrumentation feature I will have a chance to rethink all of it and remove this all. Generally, all this stuff was created for APM use case and most of it isn't required for this more focused library and narrower use case.
…fix is relased by maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates patcher code from Datadog::Tracing::Contrib to Datadog::CI::Contrib
Motivation
Reduce coupling with private tracing details. Move all contrib/integrations code to CI to be able to develop independent auto-instrumentation feature.
How to test the change?
It works if unit tests still pass