Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the right cgroup root dir on Amazon Linux #880

Merged
merged 5 commits into from
Nov 30, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[proc] added log message for cgroup root for debug
  • Loading branch information
shang-wang committed Nov 30, 2017

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 1d8839c5de0b12ee4bf60a5089188a696530351d
1 change: 1 addition & 0 deletions pkg/util/docker/cgroup.go
Original file line number Diff line number Diff line change
@@ -464,6 +464,7 @@ func parseCgroupMountPoints(r io.Reader) map[string]string {
}
}
}
log.Warnf("current cgroup root is: %s", cgroupRoot)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid log spam, I'd just log if we have an actual warning:

if len(mountPoints) == 0 {
    log.Warnf("could not locate cgroup folders in %s, please check your configuration", cgroupRoot)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I immediately realized that, change already made.

return mountPoints
}