Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omnibus] Relax pyjwt dependency #7590

Merged
merged 1 commit into from
Mar 5, 2021
Merged

[omnibus] Relax pyjwt dependency #7590

merged 1 commit into from
Mar 5, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 5, 2021

What does this PR do?

  • Relax pyjwt dependency for snowflake connector

Motivation

Additional Notes

To generate the patch I did roughly the following

git clone [email protected]:snowflakedb/snowflake-connector-python.git
cd snowflake-connector-python
git checkout 2.1.3  # current version pinned in Omnibus
git apply path/to/current/patch
nano setup.py  # change pyjwt<2.0.0 by pjwt<3.0.0
git diff > path/to/python2/patch
git diff > path/to/python3/patch

@mx-psi mx-psi changed the title [omnibus] Bump pyjwt [omnibus] Relax pyjwt dependency Mar 5, 2021
@mx-psi mx-psi added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform labels Mar 5, 2021
@mx-psi mx-psi added this to the 7.27.0 milestone Mar 5, 2021
@mx-psi mx-psi marked this pull request as ready for review March 5, 2021 08:55
@mx-psi mx-psi requested a review from a team as a code owner March 5, 2021 08:55
@mx-psi
Copy link
Member Author

mx-psi commented Mar 5, 2021

x64 builds are failing because of an unrelated issue (cargo is missing)

@mx-psi mx-psi merged commit 2a64bfb into master Mar 5, 2021
@mx-psi mx-psi deleted the mx-psi/fix-snowflake branch March 5, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants