Implement Python API for setting check metadata #4230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
added
[deprecated] team/agent-core
albertvaka
reviewed
Sep 30, 2019
| PyGILState_STATE gstate = PyGILState_Ensure(); | ||
|
|
||
| // datadog_agent.set_check_metadata(check_id, name, value) | ||
| if (!PyArg_ParseTuple(args, "sss", &check_id, &name, &value)) { |
There was a problem hiding this comment.
Don't we know the check_id already, instead of it being passed from the check itself?
There was a problem hiding this comment.
I don't think we do. You see a way?
ofek
force-pushed
the
ofek/check-metadata-api
branch
from
aa86c35
to
6020242
Compare
albertvaka
approved these changes
Sep 30, 2019
|
Superseded by #4234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows Python checks to send metadata using the
inventoriesprovider introduced in #4158