-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common Windows runner config #32623
Merged
Merged
+57
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkb7
added
changelog/no-changelog
team/windows-agent
qa/no-code-change
No code change in Agent code requiring validation
team/agent-devx-infra
labels
Jan 2, 2025
chouetz
approved these changes
Jan 3, 2025
jack0x2
approved these changes
Jan 3, 2025
sabrina-datadog
approved these changes
Jan 6, 2025
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
medium review
PR review might take time
qa/no-code-change
No code change in Agent code requiring validation
team/agent-devx-infra
team/windows-agent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add common Windows runner config
Most jobs use
.windows_docker_default
: currently 2019, future updates will bump thisJobs that need a specific version use
.windows_docker_2022
: Run on Server 2022 runners, use ltsc2022 container.windows_docker_2019
: Run on Server 2019 runners, use 1809/ltsc2019 containerMotivation
https://datadoghq.atlassian.net/browse/WINA-1194
Make it easier to update the runners/version/buildimage used by jobs
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes