Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common Windows runner config #32623

Merged
merged 10 commits into from
Jan 6, 2025
Merged

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented Jan 2, 2025

What does this PR do?

Add common Windows runner config

Most jobs use

  • .windows_docker_default: currently 2019, future updates will bump this

Jobs that need a specific version use

  • .windows_docker_2022: Run on Server 2022 runners, use ltsc2022 container
  • .windows_docker_2019: Run on Server 2019 runners, use 1809/ltsc2019 container

Motivation

https://datadoghq.atlassian.net/browse/WINA-1194

Make it easier to update the runners/version/buildimage used by jobs

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@clarkb7 clarkb7 requested review from a team as code owners January 2, 2025 18:38
@github-actions github-actions bot added the medium review PR review might take time label Jan 2, 2025
@clarkb7
Copy link
Contributor Author

clarkb7 commented Jan 6, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-06 17:26:18 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-06 18:02:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 365457a into main Jan 6, 2025
274 checks passed
@dd-mergequeue dd-mergequeue bot deleted the branden.clark/common-runner-tags branch January 6, 2025 18:02
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants