fix(notify): Mock environ in all situations #32607
Merged
+175
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
added
changelog/no-changelog
qa/no-code-change
Gitlab CI Configuration ChangesModified Jobsnotify notify:
dependencies: []
image: registry.ddbuild.io/slack-notifier:v27936653-9a2a7db-sdm-gbi-jammy@sha256:c9d1145319d1904fa72ea97904a15200d3cb684324723f9e1700bc02cc85065c
resource_group: notification
rules:
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
when: always
- if: $CI_COMMIT_BRANCH == "main"
when: always
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
when: always
script:
- GITLAB_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $GITLAB_TOKEN read_api)
|| exit $?; export GITLAB_TOKEN
- DD_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_API_KEY_ORG2 token)
|| exit $?; export DD_API_KEY
- python3 -m pip install -r requirements.txt -r tasks/libs/requirements-notifications.txt
+ - invoke -e notify.send-message -p $CI_PIPELINE_ID
+ - invoke -e notify.check-consistent-failures -p $CI_PIPELINE_ID
- - "# Do not send notifications if this is a child pipeline of another repo\n# The\
- \ triggering repo should already have its own notification system\nif [ \"$CI_PIPELINE_SOURCE\"\
- \ != \"pipeline\" ]; then\n if [ \"$DEPLOY_AGENT\" = \"true\" ]; then\n invoke\
- \ -e notify.send-message --notification-type \"deploy\"\n elif [ \"$CI_PIPELINE_SOURCE\"\
- \ != \"push\" ]; then\n invoke -e notify.send-message --notification-type \"\
- trigger\"\n else\n invoke -e notify.send-message --notification-type \"merge\"\
- \n fi\n if [ \"$CI_COMMIT_BRANCH\" = \"$CI_DEFAULT_BRANCH\" ]; then\n invoke\
- \ notify.check-consistent-failures\n fi\nelse\n echo \"This pipeline was triggered\
- \ by another repository, skipping notification.\"\nfi\n"
stage: notify
tags:
- arch:amd64
timeout: 15 minutesChanges Summary
ℹ️ Diff available in the job log. |
|
[Fast Unit Tests Report] On pipeline 52080694 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
CelianR
approved these changes
Jan 3, 2025
chouetz
force-pushed
the
nschweitzer/notify_again
branch
from
f07f675 to
b5a0888
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 1af8863 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.40 | [-0.07, +0.86] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.35 | [+0.27, +0.42] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.09 | [+0.06, +0.13] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.57, +0.75] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.07 | [-0.58, +0.72] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.06 | [-0.79, +0.91] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.00 | [-0.81, +0.80] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.13, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.01 | [-0.87, +0.86] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.88, +0.84] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.07 | [-0.20, +0.05] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.08 | [-0.85, +0.70] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.16 | [-3.37, +3.06] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.41 | [-0.48, -0.34] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.85 | [-1.52, -0.17] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-apply #32165 that was reverted by #32494
Update the unit tests so that they work in the different main branch configuration (
standardmain branch,scheduledandscheduled conductor)Motivation
Prevent failures that caused the initial revert
Describe how you validated your changes
Updated unit tests. Now the full
os.environis under controlPossible Drawbacks / Trade-offs
Additional Notes