[NPM-3666] Add dmesg to agent flare #32559
Conversation
github-actions
bot
added
component/system-probe
team/ebpf-platform
team/agent-shared-components
medium review
| "time" | ||
| ) | ||
|
|
||
| var klogRegexp = regexp.MustCompile(`<(\d+)>(.*)`) | ||
|
|
||
| func readAllDmesg() ([]byte, error) { |
There was a problem hiding this comment.
readAllDmesg() is relocated from flare/archive_linux.go
| return b[:m], nil | ||
| } | ||
|
|
||
| func parseDmesg(buffer []byte) (string, error) { |
There was a problem hiding this comment.
parseDmesg() is relocated from flare/archive_linux.go
pimlu
added
the
qa/done
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51976229 --os-family=ubuntuNote: This applies to commit f1ca4a7 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 9f2238e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_idle | memory utilization | +0.47 | [+0.43, +0.51] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.18 | [+0.09, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.12 | [-0.35, +0.59] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.10 | [-0.80, +1.01] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.08 | [-0.56, +0.72] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.08 | [-0.71, +0.86] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.01 | [-0.85, +0.87] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.12, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.81, +0.75] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.92, +0.86] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.07 | [-0.85, +0.71] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.19 | [-0.32, -0.07] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.84 | [-4.10, +2.42] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.86 | [-0.93, -0.79] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.94 | [-1.63, -0.26] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 8/10 | |
| ❌ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
What does this PR do?
This adds kernel dmesg to the agent flare.
It already existed in the security agent flare, but was not using system-probe - this PR updates it to query as root via system-probe.
Motivation
Dmesg can be useful to diagnose customer issues. This also benefits the security agent because, recent distro releases require root for dmesg. This is controlled by the sysctl
kernel.dmesg_restrict. For example, this is enabled in ubuntu 20 because of upstream changes from debian.Describe how you validated your changes
Agent flare, view
./system-probe/dmesg.logSecurity agent flare, view
./dmesgwhich should still exist, and now it works withkernel.dmesg_restrict=1.Possible Drawbacks / Trade-offs
Would be nice to use the same filepath for both flares, but I don't want to change the security agent flare.
Additional Notes