Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e][gpu] arguments in apply all functor should be []interface{} #32551

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

pducolin
Copy link
Contributor

What does this PR do?

Change ApplyT functor arguments type from []string to []interface{}

Motivation

pulumi expects an untyped interface with pulumi.All, this is currently failing this test, marked as flake

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pducolin pducolin added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 30, 2024
@pducolin pducolin requested a review from a team as a code owner December 30, 2024 14:37
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 30, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51905323 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor c83838f0eb1cfbea4afb3d4426e985e51d3661e8

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 1200.36MB 1200.36MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1200.36MB 1200.36MB 140.00MB
datadog-agent-amd64-deb 0.00MB 1191.05MB 1191.04MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.53MB 78.53MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.61MB 78.61MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.61MB 78.61MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.25MB 505.25MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.33MB 113.33MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.80MB 108.80MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.87MB 108.87MB 10.00MB
datadog-agent-aarch64-rpm -0.01MB 944.64MB 944.66MB 140.00MB
datadog-agent-arm64-deb -0.01MB 935.35MB 935.36MB 140.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51905323 --os-family=ubuntu

Note: This applies to commit f97d9be

@pducolin
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 30, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-30 16:01:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-30 16:17:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.


2024-12-30 16:51:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9f2238e into main Dec 30, 2024
234 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pducolin/fix-test-gpu-apply-all branch December 30, 2024 16:51
@github-actions github-actions bot added this to the 7.63.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants