Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info log of the error that trigger DB recreation #32549

Merged

Conversation

mellon85
Copy link
Contributor

@mellon85 mellon85 commented Dec 30, 2024

Add warning logs on DB open failures

@github-actions github-actions bot added team/remote-config short review PR is simple enough to be reviewed quickly labels Dec 30, 2024
@mellon85 mellon85 force-pushed the dario.meloni/rc-improve-logging-rc-db-open-fails branch from 68f5b44 to b9b24b6 Compare December 30, 2024 14:12
@mellon85 mellon85 force-pushed the dario.meloni/rc-improve-logging-rc-db-open-fails branch from b9b24b6 to aeb20ba Compare December 30, 2024 14:15
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 30, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51904697 --os-family=ubuntu

Note: This applies to commit b9b24b6

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 30, 2024

Uncompressed package size comparison

Comparison with ancestor c83838f0eb1cfbea4afb3d4426e985e51d3661e8

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-amd64-deb 0.00MB 113.33MB 113.33MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.87MB 108.87MB 10.00MB
datadog-agent-amd64-deb 0.00MB 1191.04MB 1191.04MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1200.36MB 1200.36MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1200.36MB 1200.36MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.53MB 78.53MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.61MB 78.61MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.61MB 78.61MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.25MB 505.25MB 70.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.80MB 108.80MB 10.00MB
datadog-agent-aarch64-rpm -0.01MB 944.64MB 944.66MB 140.00MB
datadog-agent-arm64-deb -0.01MB 935.35MB 935.36MB 140.00MB

Decision

✅ Passed

@mellon85 mellon85 changed the title Add warning logs on DB open failures Add info log of the error that trigger DB recreation Dec 30, 2024
@mellon85 mellon85 added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Dec 30, 2024
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a60fecdb-f7e5-4ce3-ac17-1f74bcd8f039

Baseline: c83838f
Comparison: aeb20ba
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.28 [-1.94, +4.49] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.93 [+0.25, +1.61] 1 Logs
quality_gate_idle memory utilization +0.40 [+0.36, +0.43] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.18 [+0.09, +0.26] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.87, +0.96] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.43, +0.51] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.93, +0.93] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.72, +0.68] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.86, +0.82] 1 Logs
file_tree memory utilization -0.06 [-0.19, +0.08] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.08 [-0.86, +0.69] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.53 [-0.60, -0.47] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.63 [-1.43, +0.16] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@mellon85 mellon85 marked this pull request as ready for review December 30, 2024 15:18
@mellon85 mellon85 requested a review from a team as a code owner December 30, 2024 15:18
@mellon85
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 30, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-30 15:49:35 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-30 16:24:44 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6278749 into main Dec 30, 2024
241 of 244 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dario.meloni/rc-improve-logging-rc-db-open-fails branch December 30, 2024 16:24
@github-actions github-actions bot added this to the 7.63.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/improvement changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/remote-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants