-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route agent crash detection through agent telemetry component #32515
base: main
Are you sure you want to change the base?
Conversation
cfcbfcb
to
d437007
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=52064516 --os-family=ubuntu Note: This applies to commit f98bcf7 |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 0092d92 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.56 | [+1.49, +1.63] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +1.41 | [-1.81, +4.62] | 1 | Logs |
➖ | file_tree | memory utilization | +0.38 | [+0.26, +0.51] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.37 | [-0.44, +1.18] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.18 | [-0.29, +0.65] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.60, +0.78] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.06 | [+0.03, +0.09] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.79, +0.85] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.02 | [-0.06, +0.10] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.81, +0.84] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.12, +0.14] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.80, +0.76] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.02 | [-0.66, +0.62] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.03 | [-0.86, +0.79] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.02 | [-2.69, -1.35] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
0ca8258
to
42dbfba
Compare
42dbfba
to
672e942
Compare
672e942
to
40bf0b9
Compare
releasenotes/notes/agent-tel-bsod-payload-791ab2c7f553abb4.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: cecilia saixue watt <[email protected]>
What does this PR do?
agentbsod
).agentbsod
events) are routed. Currently it has been using the APM Tracer general mechanism as a semi-structured log message. With this PR change, information will be sent as a structural payload via the newer Agent Telemetry mechanism.Motivation
Describe how you validated your changes
Added following unit tests
Possible Drawbacks / Trade-offs
Additional Notes