Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last updated version to match release version #32510

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

louis-cqrl
Copy link
Contributor

What does this PR do?

This PR aims to fix the lastUpdated field from the URI replacers to match the release version of Agent.

Motivation

Some unexpected behaviour could appear on the backend side when the scrubbing based on the versioning of the replacer.

Describe how you validated your changes

No behaviour change

Possible Drawbacks / Trade-offs

Additional Notes

@louis-cqrl louis-cqrl added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 25, 2024
@louis-cqrl louis-cqrl requested a review from a team as a code owner December 25, 2024 00:29
@louis-cqrl louis-cqrl requested review from ogaca-dd and pgimalac and removed request for ogaca-dd December 25, 2024 00:29
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 25, 2024
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 272716faa23e812a822c030ab28437f9a49957fa

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.03MB ⚠️ 1200.09MB 1200.06MB 140.00MB
datadog-agent-x86_64-suse 0.03MB ⚠️ 1200.09MB 1200.06MB 140.00MB
datadog-agent-aarch64-rpm 0.03MB ⚠️ 944.35MB 944.33MB 140.00MB
datadog-agent-amd64-deb 0.03MB ⚠️ 1190.80MB 1190.77MB 140.00MB
datadog-agent-arm64-deb 0.03MB ⚠️ 935.08MB 935.06MB 140.00MB
datadog-heroku-agent-amd64-deb 0.03MB ⚠️ 505.20MB 505.17MB 70.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51783709 --os-family=ubuntu

Note: This applies to commit 7c35212

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 94045258-d631-47e7-aef3-0a6363c63fee

Baseline: 272716f
Comparison: 7c35212
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.03 [-1.24, +5.30] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.31 [-0.50, +1.12] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.10 [-0.55, +0.75] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.69, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.84, +0.90] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.03 [-0.03, +0.08] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.86, +0.89] 1 Logs
file_tree memory utilization -0.00 [-0.13, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.12] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.91, +0.89] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.04 [-0.51, +0.42] 1 Logs
quality_gate_idle_all_features memory utilization -0.05 [-0.13, +0.03] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.09 [-0.12, -0.05] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.11 [-0.89, +0.66] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.68 [-1.36, -0.00] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@louis-cqrl
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 26, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-26 09:16:21 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-26 09:50:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b3f6090 into main Dec 26, 2024
244 checks passed
@dd-mergequeue dd-mergequeue bot deleted the louis-cqrl/fix-mismatch-replacer-version branch December 26, 2024 09:50
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants