Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USMON-1319] usm: Add raw tracepoint for netif_receive_skb #32496

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

guyarb
Copy link
Contributor

@guyarb guyarb commented Dec 24, 2024

What does this PR do?

Introducing a raw tracepoint version for netif_receive_skb

Motivation

Eliminating execution misses we have with the original tracepoint.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@guyarb guyarb added changelog/no-changelog team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Dec 24, 2024
@guyarb guyarb requested a review from a team as a code owner December 24, 2024 10:31
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Dec 24, 2024
@guyarb guyarb force-pushed the guy.arbitman/raw-tp-netif branch from 593320e to 2fea32b Compare December 24, 2024 10:41
@guyarb guyarb marked this pull request as draft December 24, 2024 10:46
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 24, 2024
@guyarb guyarb changed the title usm: Remove redundant duplication of flushing events usm: Add raw tracepoint for netif_receive_skb Dec 24, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 24, 2024

[Fast Unit Tests Report]

On pipeline 51770100 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 24, 2024

Uncompressed package size comparison

Comparison with ancestor 00ecffe0b51f3edb23173036d5d547eaf5ebd907

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.19MB ⚠️ 944.43MB 944.25MB 140.00MB
datadog-agent-arm64-deb 0.19MB ⚠️ 935.19MB 935.00MB 140.00MB
datadog-agent-x86_64-rpm 0.18MB ⚠️ 1200.16MB 1199.98MB 140.00MB
datadog-agent-x86_64-suse 0.18MB ⚠️ 1200.16MB 1199.98MB 140.00MB
datadog-agent-amd64-deb 0.18MB ⚠️ 1190.90MB 1190.71MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.11MB 505.11MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 24, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51770100 --os-family=ubuntu

Note: This applies to commit 36f3e09

Copy link

cit-pr-commenter bot commented Dec 24, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e1afaf17-6534-48aa-94c3-e25ed062fd56

Baseline: 00ecffe
Comparison: 36f3e09
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.12 [+0.08, +0.15] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.71, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.77, +0.87] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.62, +0.67] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.03 [-0.44, +0.49] 1 Logs
file_tree memory utilization +0.01 [-0.12, +0.14] 1 Logs
quality_gate_logs % cpu utilization +0.00 [-3.23, +3.23] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.88, +0.79] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.79, +0.68] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.07 [-0.95, +0.80] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.08 [-0.75, +0.59] 1 Logs
quality_gate_idle_all_features memory utilization -0.25 [-0.33, -0.17] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.29 [-1.07, +0.49] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.16 [-1.22, -1.10] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@guyarb guyarb force-pushed the guy.arbitman/raw-tp-netif branch from 8580906 to 36f3e09 Compare December 24, 2024 15:05
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Dec 24, 2024
@guyarb guyarb marked this pull request as ready for review December 25, 2024 06:33
@guyarb guyarb changed the title usm: Add raw tracepoint for netif_receive_skb [USMON-1319] usm: Add raw tracepoint for netif_receive_skb Dec 25, 2024
Copy link
Contributor

@vitkyrka vitkyrka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the PR description seems to be copied from some other PR and doesn't match the code.

@guyarb
Copy link
Contributor Author

guyarb commented Dec 26, 2024

The text in the PR description seems to be copied from some other PR and doesn't match the code.

True, I fixed it

@guyarb
Copy link
Contributor Author

guyarb commented Dec 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 26, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-26 09:39:07 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-26 10:22:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2ae3236 into main Dec 26, 2024
301 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guy.arbitman/raw-tp-netif branch December 26, 2024 10:22
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 26, 2024
amitslavin added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants