Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fleet): More flaky mitigations again #32495

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented Dec 24, 2024

What does this PR do?

  • Removes Fedora tests for readability
  • More retries on Docker APM instrumentation
  • More safeties & logging around Docker in E2E tests

Motivation

Less flakes

Describe how you validated your changes

E2Es

Possible Drawbacks / Trade-offs

Additional Notes

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Dec 24, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 24, 2024
@BaptisteFoy BaptisteFoy marked this pull request as ready for review December 24, 2024 10:41
@BaptisteFoy BaptisteFoy requested review from a team as code owners December 24, 2024 10:41
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 24, 2024

Uncompressed package size comparison

Comparison with ancestor 653ea3185feb58e45ce53504a61b5e0724b8593a

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1190.70MB 1190.70MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1199.96MB 1199.96MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1199.96MB 1199.96MB 140.00MB
datadog-agent-arm64-deb 0.00MB 934.99MB 934.99MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 944.24MB 944.24MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.11MB 505.11MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 24, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51764782 --os-family=ubuntu

Note: This applies to commit f66e8e5

Copy link
Contributor

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/hello-flaky-my-old-friend branch from 865edac to 4e4bc47 Compare December 24, 2024 11:53
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/hello-flaky-my-old-friend branch from 4e4bc47 to f66e8e5 Compare December 24, 2024 12:20
@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 24, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-24 15:50:54 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-24 16:24:10 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f93202d into main Dec 24, 2024
238 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/hello-flaky-my-old-friend branch December 24, 2024 16:24
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants