usm: file registry: Save block reason #32468
Conversation
When we block a path, save the reason and expose it via the debug endpoint, as a debugging aid. For common errors such as "not a Go program", we save a summary instead of the full error message to reduce memory usage.
vitkyrka
added
changelog/no-changelog
team/usm
github-actions
bot
added
component/system-probe
short review
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51739000 --os-family=ubuntuNote: This applies to commit 6b54dd6 |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 68a6fd3 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +1.65 | [+0.96, +2.35] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.31 | [+0.61, +2.00] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.06 | [+1.00, +1.12] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.14 | [-0.67, +0.94] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.03 | [-0.82, +0.87] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.11, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.80, +0.80] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.65, +0.64] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.01 | [-0.91, +0.89] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.77, +0.72] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.05 | [-0.13, +0.03] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.07 | [-0.19, +0.06] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.14 | [-0.61, +0.33] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.15 | [-3.33, +3.02] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.17 | [-0.93, +0.59] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.81 | [-0.84, -0.78] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
Devflow running:
|
Conflicts: pkg/network/usm/utils/file_registry.go pkg/network/usm/utils/file_registry_test.go
Conflicts: pkg/network/usm/utils/file_registry.go pkg/network/usm/utils/file_registry_test.go (cherry picked from commit ed59a4d)
What does this PR do?
When we block a path, save the reason and expose it via the debug endpoint, as a debugging aid. For common errors such as "not a Go program", we save a summary instead of the full error message to reduce memory usage.
Motivation
https://datadoghq.atlassian.net/wiki/spaces/UT/pages/4105764896
Describe how you validated your changes
Automated test updated to check for this.
Also manually tested by checking the debug endpoint.
Possible Drawbacks / Trade-offs
Additional Notes