Remove files in pkg/util #32450
Merged
Remove files in pkg/util #32450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgimalac
added
changelog/no-changelog
team/agent-shared-components
qa/done
github-actions
bot
added
component/system-probe
long review
FlorianVeaux
approved these changes
Dec 23, 2024
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51901404 --os-family=ubuntuNote: This applies to commit f8a3e2c |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
guyarb
approved these changes
Dec 23, 2024
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 055764b Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.28 | [-0.98, +5.55] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.79 | [+0.10, +1.47] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.52 | [+0.47, +0.58] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.22 | [+0.19, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.15 | [+0.07, +0.23] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.07 | [-0.71, +0.85] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.07 | [-0.80, +0.93] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.06 | [-0.58, +0.70] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.83, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.72, +0.78] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.13, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.06 | [-0.95, +0.83] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.18 | [-0.96, +0.59] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.25 | [-0.39, -0.12] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.43 | [-0.90, +0.04] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 9/10 | |
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
louis-cqrl
reviewed
Dec 23, 2024
vickenty
approved these changes
Dec 23, 2024
louis-cqrl
approved these changes
Dec 23, 2024
mx-psi
approved these changes
Dec 23, 2024
NouemanKHAL
approved these changes
Dec 30, 2024
wdhif
approved these changes
Dec 30, 2024
clamoriniere
approved these changes
Dec 30, 2024
Go Package Import DifferencesBaseline: 055764b
|
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would advise reviewing commit by commit. Each commit basically moves one file.
What does this PR do?
Remove every file in
pkg/util.Motivation
#32174 has shown that
pkg/utilis a mess and a bad concept, in particular considering the way Go's dead code elimination works.Describe how you validated your changes
There should be no functional change, just moving things around and renaming.
CI should be enough.
Possible Drawbacks / Trade-offs
Additional Notes
I created new packages and moved some functions to existing packages when it made sense.
I also deleted functions when they were actually unused.