Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Add namespace ID field resolver for ptrace #32413

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

spikat
Copy link
Contributor

@spikat spikat commented Dec 20, 2024

What does this PR do?

It adds process cache entry NSID field resolver (NB: the field was already present and used in ebpfless mode).

Motivation

Resolving it only once per process for all its ptrace calls will reduce drastically the number of proc resolutions.

But more important: as it's now cached, we "no longer" have a race where it cannot be resolved anymore due to process termination, resulting in tracee resolution errors.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@spikat spikat added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Dec 20, 2024
@spikat spikat added this to the 7.62.0 milestone Dec 20, 2024
@spikat spikat requested a review from a team as a code owner December 20, 2024 10:42
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Dec 20, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 20, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51655781 --os-family=ubuntu

Note: This applies to commit 7de87b3

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 20, 2024

Uncompressed package size comparison

Comparison with ancestor 395cb8e8c789c6fd702be34a2c381ac7564b962e

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1187.96MB 1187.96MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1197.22MB 1197.22MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1197.22MB 1197.22MB 140.00MB
datadog-agent-arm64-deb 0.00MB 933.94MB 933.94MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 943.18MB 943.18MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 504.87MB 504.87MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.33MB 113.33MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.40MB 113.40MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.80MB 108.80MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.87MB 108.87MB 10.00MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Dec 20, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8a2a4f82-2776-473e-89b9-45bcd21138eb

Baseline: 395cb8e
Comparison: 7de87b3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.65 [+0.96, +2.34] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.81 [+0.00, +1.62] 1 Logs
quality_gate_logs % cpu utilization +0.18 [-3.07, +3.43] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.16 [-0.31, +0.62] 1 Logs
quality_gate_idle_all_features memory utilization +0.12 [+0.03, +0.21] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.09 [-0.75, +0.94] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.09 [+0.02, +0.15] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.60, +0.69] 1 Logs
quality_gate_idle memory utilization +0.04 [+0.01, +0.07] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.00 [-0.84, +0.84] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.71, +0.71] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.93, +0.90] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.11 [-0.89, +0.66] 1 Logs
file_tree memory utilization -0.14 [-0.28, -0.01] 1 Logs
otel_to_otel_logs ingress throughput -2.16 [-2.86, -1.46] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@spikat
Copy link
Contributor Author

spikat commented Dec 20, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-20 15:02:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-20 15:35:42 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1c318b7 into main Dec 20, 2024
230 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jrs/add-ns-to-pce branch December 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants