Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): Update to go 1.21.11 #32408

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(go): Update to go 1.21.11 #32408

merged 3 commits into from
Dec 23, 2024

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Dec 19, 2024

What does this PR do?

Update to go 1.21.11

Motivation

Agent 6 release

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

misteriaud and others added 2 commits December 19, 2024 20:09
@misteriaud @agent-platform-auto-pr @chouetz
[ASCII] Update Go version to 1.21.11 (#26360)
7b47969 
Co-authored-by: agent-platform-auto-pr[bot] <agent-platform-auto-pr[bot]@users.noreply.github.com>
@chouetz
Update the buildimage for test
7ed6589
@chouetz chouetz added the major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams label Dec 19, 2024
@chouetz chouetz requested review from a team as code owners December 19, 2024 19:12
@chouetz chouetz requested a review from ogaca-dd December 19, 2024 19:12
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=51721208 --os-family=ubuntu

ogaca-dd
ogaca-dd approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for files owned by ASC

@chouetz
Copy link
Member Author

chouetz commented Dec 20, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.

2024-12-20 11:41:55 UTC ℹ️ Gitlab pipeline started

Started pipeline #51648532

@chouetz chouetz requested review from a team as code owners December 23, 2024 08:20
@chouetz
Copy link
Member Author

chouetz commented Dec 23, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Dec 23, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.

2024-12-23 09:55:24 UTC ℹ️ Gitlab pipeline started

Started pipeline #51721208

@chouetz chouetz added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Dec 23, 2024
@chouetz
Copy link
Member Author

chouetz commented Dec 23, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 23, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-23 15:54:52 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 6.53.x is 36m.

2024-12-23 16:30:48 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit d9f3538 into 6.53.x Dec 23, 2024
289 of 294 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/go_update branch December 23, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF approved these changes

@ogaca-dd ogaca-dd ogaca-dd approved these changes

Assignees
No one assigned
Labels
major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-devx-loops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chouetz @ogaca-dd @brett0000FF @misteriaud