Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btfhub-sync: switch to ubuntu-22.04 explicitly #32396

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Dec 19, 2024

What does this PR do?

Ubuntu 24.04 github actions image is getting rolled out under ubuntu-latest and this is causing some issues with the btfhub sync job. This PR forces the usage of ubuntu 22.04 while we investigate migrating to 24.04

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-security labels Dec 19, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51558522 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@paulcacheux paulcacheux added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 19, 2024
@paulcacheux paulcacheux marked this pull request as ready for review December 19, 2024 14:11
@paulcacheux paulcacheux requested a review from a team as a code owner December 19, 2024 14:11
@paulcacheux paulcacheux added the qa/done QA done before merge and regressions are covered by tests label Dec 19, 2024
@paulcacheux paulcacheux removed the qa/done QA done before merge and regressions are covered by tests label Dec 19, 2024
@paulcacheux
Copy link
Contributor Author

/merge

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 22022a5b4c2b4f27c34c3a897b3151902435624c

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1187.70MB 1187.70MB 140.00MB
datadog-agent-arm64-deb 0.00MB 933.68MB 933.68MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.85MB 108.85MB 10.00MB
datadog-agent-x86_64-rpm -0.00MB 1196.96MB 1196.96MB 140.00MB
datadog-agent-x86_64-suse -0.00MB 1196.96MB 1196.96MB 140.00MB
datadog-agent-aarch64-rpm -0.00MB 942.92MB 942.92MB 140.00MB
datadog-heroku-agent-amd64-deb -0.00MB 504.86MB 504.86MB 70.00MB

Decision

✅ Passed

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-19 14:14:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-19 15:27:06 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 30m.


2024-12-19 16:03:45 UTC ℹ️ MergeQueue: This merge request was merged

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c03f8927-c6bb-4806-a67f-f1b5024bcec7

Baseline: 22022a5
Comparison: 7d3fa75
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +0.53 [-0.13, +1.19] 1 Logs
quality_gate_idle_all_features memory utilization +0.39 [+0.30, +0.48] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.28 [+0.22, +0.34] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.20 [-0.26, +0.66] 1 Logs
file_tree memory utilization +0.19 [+0.06, +0.33] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.06 [-0.82, +0.93] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.89, +0.86] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.13, +0.09] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.03 [-0.97, +0.90] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.83, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.69, +0.60] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.09 [-0.87, +0.69] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.10 [-0.86, +0.67] 1 Logs
quality_gate_idle memory utilization -0.32 [-0.36, -0.29] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.78 [-1.46, -0.11] 1 Logs
quality_gate_logs % cpu utilization -2.18 [-5.32, +0.97] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

@dd-mergequeue dd-mergequeue bot merged commit 7525976 into main Dec 19, 2024
262 of 264 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/fix-btfhub-22.04 branch December 19, 2024 16:03
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants