Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Fix test connect #32394

Merged
merged 4 commits into from
Dec 19, 2024
Merged

[CWS] Fix test connect #32394

merged 4 commits into from
Dec 19, 2024

Conversation

mftoure
Copy link
Contributor

@mftoure mftoure commented Dec 19, 2024

What does this PR do?

This PR aims to fix the connect event tests

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@mftoure mftoure added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Dec 19, 2024
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Dec 19, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51564151 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 5d81b5d4377ca3be9dac2134700683eedb516337

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.06MB ⚠️ 943.06MB 943.00MB 140.00MB
datadog-heroku-agent-amd64-deb 0.05MB ⚠️ 505.09MB 505.05MB 70.00MB
datadog-agent-arm64-deb 0.04MB ⚠️ 933.82MB 933.78MB 140.00MB
datadog-agent-x86_64-rpm 0.04MB ⚠️ 1197.04MB 1197.01MB 140.00MB
datadog-agent-x86_64-suse 0.04MB ⚠️ 1197.04MB 1197.01MB 140.00MB
datadog-agent-amd64-deb 0.01MB ⚠️ 1187.78MB 1187.77MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.78MB 55.78MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.84MB 108.84MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51564151 --os-family=ubuntu

Note: This applies to commit b5b8849

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 56bf9c7a-c3fd-41b5-ad0a-247c0a0a2717

Baseline: 5d81b5d
Comparison: b5b8849
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.70 [-0.30, +5.69] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.55 [+0.83, +2.28] 1 Logs
file_tree memory utilization +1.49 [+1.35, +1.62] 1 Logs
quality_gate_idle_all_features memory utilization +0.87 [+0.74, +0.99] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.49 [+0.37, +0.61] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.49 [-0.28, +1.25] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.12 [-0.33, +0.58] 1 Logs
otel_to_otel_logs ingress throughput +0.10 [-0.59, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.08 [-0.78, +0.94] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.71, +0.78] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
quality_gate_idle memory utilization +0.00 [-0.04, +0.04] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.85, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.10] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.98, +0.86] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.13 [-0.90, +0.64] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@mftoure mftoure marked this pull request as ready for review December 19, 2024 15:35
@mftoure mftoure requested a review from a team as a code owner December 19, 2024 15:35
@mftoure mftoure added this to the 7.62.0 milestone Dec 19, 2024
@mftoure
Copy link
Contributor Author

mftoure commented Dec 19, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-19 15:51:31 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 32m.


2024-12-19 16:26:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2ca6541 into main Dec 19, 2024
230 checks passed
@dd-mergequeue dd-mergequeue bot deleted the momar/fix-test-connect branch December 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants