Add retry ability to configsync comp #32390
Conversation
hush-hush
added
changelog/no-changelog
team/agent-shared-components
qa/done
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51666834 --os-family=ubuntuNote: This applies to commit b8f01aa |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 8cb7df0 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +3.19 | [-0.10, +6.47] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.66 | [+0.58, +0.74] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.53 | [-0.13, +1.20] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.49 | [+0.40, +0.58] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.38 | [-0.08, +0.85] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.19 | [+0.16, +0.23] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.11 | [-0.80, +1.02] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.07 | [-0.70, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.83, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.03 | [-0.61, +0.68] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.01 | [-0.84, +0.87] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.66, +0.68] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.04 | [-0.83, +0.75] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.60 | [-0.74, -0.47] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.70 | [-1.38, -0.02] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
| cancel() | ||
| return nil | ||
| case <-time.After(deps.SyncParams.Delay): | ||
| return nil, deps.Log.Errorf("failed to sync config at startup, is the core agent listening on '%s' ?", url.String()) |
There was a problem hiding this comment.
Just checking whether it's intentional, but if this error is returned due to all retries failing, that will cause the app to exit due to fx graph construction failing.
There was a problem hiding this comment.
Yes, I think starting the process in a failed state is no OK. Especially with k8s which might restart it and fix the error.
There was a problem hiding this comment.
Yup, I think that makes sense.
hush-hush
force-pushed
the
maxime/add-retry-to-configsync
branch
2 times, most recently
from
3ceef38 to
2a2c5a2
Compare
hush-hush
force-pushed
the
maxime/add-retry-to-configsync
branch
from
2a2c5a2 to
b8f01aa
Compare
What does this PR do?
Add a retry mechanism to
configsyncwhen asked to synchronize configuration on startup. This also fails binary init if we can't sync on init to avoid starting with a wrong configuration.Describe how you validated your changes
Running the CI and testing on staging.