Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2629] Backport Update golang.org/x/net to v33 #32386

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

louis-cqrl
Copy link
Contributor

What does this PR do?

This PR backports the update of golang.org/x/net package to v33

Motivation

We have tagged version v0.33.0 of golang.org/x/net in order to address a security issue.
Version v0.33.0 of golang.org/x/net fixes a vulnerability in the golang.org/x/net/html package which could cause a denial of service.

An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing.
This is CVE-2024-45338 and Go issue https://go.dev/issue/70906.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@louis-cqrl louis-cqrl requested review from a team as code owners December 19, 2024 09:17
@louis-cqrl louis-cqrl requested review from IbraheemA and dustmop and removed request for a team December 19, 2024 09:17
@louis-cqrl louis-cqrl added backport/7.61.x Automatically create a backport PR to 7.61.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation and removed component/system-probe labels Dec 19, 2024
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Dec 19, 2024
@louis-cqrl louis-cqrl changed the title Backport Update golang.org/x/net to v33 [ASCII-2629] Backport Update golang.org/x/net to v33 Dec 19, 2024
@FlorentClarret
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-20 08:03:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 7.61.x is 29m.


2024-12-20 08:41:14 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 54b17d2 into 7.61.x Dec 20, 2024
421 checks passed
@dd-mergequeue dd-mergequeue bot deleted the louis-cqrl/update-golang.org/x/net-7.61 branch December 20, 2024 08:41
@github-actions github-actions bot added this to the 7.61.0 milestone Dec 20, 2024
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.61.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.61.x 7.61.x
# Navigate to the new working tree
cd .worktrees/backport-7.61.x
# Create a new branch
git switch --create backport-32386-to-7.61.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 54b17d23c750eb4e8c461e42d5e0c70a72d5c965
# Push it to GitHub
git push --set-upstream origin backport-32386-to-7.61.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.61.x

Then, create a pull request where the base branch is 7.61.x and the compare/head branch is backport-32386-to-7.61.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.61.x Automatically create a backport PR to 7.61.x changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants