Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): [agent6] Backport .github information from main #32383

Merged
merged 6 commits into from
Dec 20, 2024
Merged

fix(ci): [agent6] Backport .github information from main #32383

merged 6 commits into from
Dec 20, 2024

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Dec 19, 2024

What does this PR do?

Backport .github information from main:

  • CODEOWNERS file
  • workflows

Motivation

Have a similar PR experience on agent6 branch as on main. Use up to date and secure github actions.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 19, 2024
@chouetz chouetz requested review from a team as code owners December 19, 2024 09:01
@chouetz chouetz requested a review from hush-hush December 19, 2024 09:01
@chouetz chouetz changed the title fix(ci): Backport .github information from main fix(ci): [agent6] Backport .github information from main Dec 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=51638478 --os-family=ubuntu

hush-hush
hush-hush reviewed Dec 19, 2024
View reviewed changes
.github/workflows/buildimages-update.yml
echo "RESULT=true" >> $GITHUB_OUTPUT
else
echo "RESULT=false" >> $GITHUB_OUTPUT
fi

- name: Checkout branch
uses: actions/checkout@v4
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use actions/[email protected] instead ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the hash is a security good practise (and dependabot manages this correctly, by updating the comment when the hash changes)

@chouetz chouetz requested a review from a team as a code owner December 19, 2024 16:45
@github-actions GitHub Actions
Copy link
Contributor

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 36a2a3a and 8750e47.

tl;dr

Use these benchmarks as an insight tool during development.

  1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

  2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats 
goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            92.32µ ± 3%   90.46µ ± 3%       ~ (p=0.218 n=10)
api-gateway-kong-appsec.json                       72.60µ ± 3%   70.26µ ± 3%  -3.21% (p=0.009 n=10)
api-gateway-kong.json                              69.38µ ± 1%   69.99µ ± 4%       ~ (p=0.796 n=10)
api-gateway-non-proxy-async.json                   107.9µ ± 2%   109.3µ ± 3%       ~ (p=0.190 n=10)
api-gateway-non-proxy.json                         107.2µ ± 1%   109.6µ ± 2%  +2.27% (p=0.009 n=10)
api-gateway-websocket-connect.json                 72.86µ ± 2%   71.48µ ± 1%  -1.89% (p=0.004 n=10)
api-gateway-websocket-default.json                 66.21µ ± 2%   64.76µ ± 2%  -2.20% (p=0.011 n=10)
api-gateway-websocket-disconnect.json              67.23µ ± 3%   65.33µ ± 1%  -2.83% (p=0.005 n=10)
api-gateway.json                                   118.9µ ± 2%   118.2µ ± 1%       ~ (p=0.382 n=10)
application-load-balancer.json                     65.86µ ± 2%   66.95µ ± 2%  +1.65% (p=0.019 n=10)
cloudfront.json                                    48.61µ ± 2%   50.29µ ± 3%  +3.45% (p=0.009 n=10)
cloudwatch-events.json                             40.07µ ± 2%   40.07µ ± 2%       ~ (p=0.529 n=10)
cloudwatch-logs.json                               68.75µ ± 1%   69.00µ ± 2%       ~ (p=0.684 n=10)
custom.json                                        32.59µ ± 1%   32.94µ ± 2%  +1.06% (p=0.027 n=10)
dynamodb.json                                      95.82µ ± 2%   97.37µ ± 2%  +1.62% (p=0.003 n=10)
empty.json                                         31.18µ ± 3%   31.71µ ± 2%       ~ (p=0.075 n=10)
eventbridge-custom.json                            44.27µ ± 1%   45.19µ ± 2%  +2.08% (p=0.000 n=10)
http-api.json                                      75.51µ ± 2%   75.77µ ± 3%       ~ (p=0.190 n=10)
kinesis-batch.json                                 73.45µ ± 1%   74.27µ ± 2%  +1.12% (p=0.009 n=10)
kinesis.json                                       56.09µ ± 2%   56.30µ ± 3%       ~ (p=0.631 n=10)
s3.json                                            61.96µ ± 5%   61.47µ ± 3%       ~ (p=0.529 n=10)
sns-batch.json                                     92.01µ ± 1%   92.18µ ± 1%       ~ (p=0.353 n=10)
sns.json                                           66.89µ ± 3%   65.68µ ± 2%       ~ (p=0.247 n=10)
snssqs.json                                        115.4µ ± 2%   112.4µ ± 1%  -2.59% (p=0.000 n=10)
snssqs_no_dd_context.json                          101.9µ ± 2%   102.7µ ± 3%       ~ (p=0.393 n=10)
sqs-aws-header.json                                55.90µ ± 2%   57.54µ ± 2%  +2.94% (p=0.000 n=10)
sqs-batch.json                                     94.34µ ± 3%   96.77µ ± 4%  +2.58% (p=0.004 n=10)
sqs.json                                           69.61µ ± 1%   70.47µ ± 3%  +1.23% (p=0.043 n=10)
sqs_no_dd_context.json                             63.54µ ± 2%   64.22µ ± 1%       ~ (p=0.481 n=10)
geomean                                            69.46µ        69.66µ       +0.29%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.18Ki ± 0%   37.18Ki ± 0%       ~ (p=0.971 n=10)
api-gateway-kong-appsec.json                      26.78Ki ± 0%   26.79Ki ± 0%       ~ (p=0.867 n=10)
api-gateway-kong.json                             24.27Ki ± 0%   24.28Ki ± 0%       ~ (p=0.725 n=10)
api-gateway-non-proxy-async.json                  48.00Ki ± 0%   48.00Ki ± 0%       ~ (p=0.403 n=10)
api-gateway-non-proxy.json                        47.21Ki ± 0%   47.23Ki ± 0%       ~ (p=0.255 n=10)
api-gateway-websocket-connect.json                25.41Ki ± 0%   25.41Ki ± 0%       ~ (p=0.698 n=10)
api-gateway-websocket-default.json                21.31Ki ± 0%   21.31Ki ± 0%       ~ (p=0.725 n=10)
api-gateway-websocket-disconnect.json             21.10Ki ± 0%   21.09Ki ± 0%       ~ (p=0.515 n=10)
api-gateway.json                                  49.49Ki ± 0%   49.47Ki ± 0%       ~ (p=0.165 n=10)
application-load-balancer.json                    23.19Ki ± 0%   23.19Ki ± 0%       ~ (p=0.810 n=10)
cloudfront.json                                   17.58Ki ± 0%   17.58Ki ± 0%       ~ (p=0.565 n=10)
cloudwatch-events.json                            11.64Ki ± 0%   11.64Ki ± 0%       ~ (p=1.000 n=10)
cloudwatch-logs.json                              53.29Ki ± 0%   53.29Ki ± 0%       ~ (p=0.541 n=10)
custom.json                                       9.667Ki ± 0%   9.666Ki ± 0%       ~ (p=0.724 n=10)
dynamodb.json                                     40.71Ki ± 0%   40.70Ki ± 0%       ~ (p=0.986 n=10)
empty.json                                        9.241Ki ± 0%   9.240Ki ± 0%       ~ (p=0.697 n=10)
eventbridge-custom.json                           13.39Ki ± 0%   13.38Ki ± 0%  -0.11% (p=0.041 n=10)
http-api.json                                     23.73Ki ± 0%   23.71Ki ± 0%  -0.11% (p=0.037 n=10)
kinesis-batch.json                                26.99Ki ± 0%   26.97Ki ± 0%       ~ (p=0.753 n=10)
kinesis.json                                      17.75Ki ± 0%   17.78Ki ± 0%       ~ (p=0.078 n=10)
s3.json                                           20.35Ki ± 0%   20.32Ki ± 0%  -0.13% (p=0.017 n=10)
sns-batch.json                                    38.59Ki ± 0%   38.59Ki ± 0%       ~ (p=0.754 n=10)
sns.json                                          23.89Ki ± 0%   23.91Ki ± 0%       ~ (p=0.448 n=10)
snssqs.json                                       50.66Ki ± 0%   50.61Ki ± 0%       ~ (p=0.060 n=10)
snssqs_no_dd_context.json                         44.77Ki ± 0%   44.81Ki ± 0%  +0.09% (p=0.034 n=10)
sqs-aws-header.json                               18.81Ki ± 0%   18.83Ki ± 1%       ~ (p=0.724 n=10)
sqs-batch.json                                    41.57Ki ± 0%   41.57Ki ± 0%       ~ (p=0.796 n=10)
sqs.json                                          25.54Ki ± 0%   25.50Ki ± 1%       ~ (p=0.305 n=10)
sqs_no_dd_context.json                            20.63Ki ± 0%   20.65Ki ± 0%       ~ (p=0.579 n=10)
geomean                                           25.69Ki        25.68Ki       -0.00%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             628.5 ± 0%   628.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        487.0 ± 0%   487.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               465.0 ± 0%   465.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    724.0 ± 0%   724.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy.json                          715.0 ± 0%   715.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  452.0 ± 0%   452.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  378.0 ± 0%   378.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               368.5 ± 0%   368.0 ± 0%       ~ (p=0.650 n=10)
api-gateway.json                                    790.0 ± 0%   789.5 ± 0%       ~ (p=0.650 n=10)
application-load-balancer.json                      352.0 ± 0%   352.0 ± 0%       ~ (p=1.000 n=10)
cloudfront.json                                     283.0 ± 0%   283.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-events.json                              219.0 ± 0%   219.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-logs.json                                214.0 ± 0%   214.0 ± 0%       ~ (p=1.000 n=10)
custom.json                                         167.0 ± 1%   167.0 ± 1%       ~ (p=1.000 n=10)
dynamodb.json                                       587.5 ± 0%   587.5 ± 0%       ~ (p=1.000 n=10)
empty.json                                          159.0 ± 0%   159.0 ± 0%       ~ (p=1.000 n=10)
eventbridge-custom.json                             253.0 ± 0%   253.0 ± 0%       ~ (p=1.000 n=10)
http-api.json                                       431.5 ± 0%   431.0 ± 0%       ~ (p=0.350 n=10)
kinesis-batch.json                                  390.0 ± 0%   389.5 ± 0%       ~ (p=0.650 n=10)
kinesis.json                                        284.0 ± 0%   284.0 ± 0%       ~ (p=0.697 n=10)
s3.json                                             357.0 ± 0%   357.0 ± 0%       ~ (p=0.124 n=10)
sns-batch.json                                      454.0 ± 0%   454.0 ± 0%       ~ (p=0.875 n=10)
sns.json                                            322.0 ± 0%   322.0 ± 0%       ~ (p=0.518 n=10)
snssqs.json                                         445.0 ± 0%   444.0 ± 0%  -0.22% (p=0.022 n=10)
snssqs_no_dd_context.json                           398.0 ± 0%   399.0 ± 1%       ~ (p=0.070 n=10)
sqs-aws-header.json                                 273.0 ± 0%   273.0 ± 1%       ~ (p=0.825 n=10)
sqs-batch.json                                      502.0 ± 0%   502.5 ± 0%       ~ (p=0.698 n=10)
sqs.json                                            351.0 ± 1%   350.0 ± 1%       ~ (p=0.389 n=10)
sqs_no_dd_context.json                              323.5 ± 0%   324.0 ± 1%       ~ (p=0.661 n=10)
geomean                                             375.6        375.5       -0.02%
¹ all samples are equal

@chouetz chouetz requested review from a team as code owners December 20, 2024 08:23
@chouetz
Copy link
Member Author

chouetz commented Dec 20, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-20 10:22:41 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 6.53.x is 0s.

2024-12-20 10:58:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 35074a1 into 6.53.x Dec 20, 2024
147 of 150 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/workflow_6 branch December 20, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hush-hush hush-hush hush-hush left review comments

@AliDatadog AliDatadog AliDatadog approved these changes

@amenasria amenasria amenasria approved these changes

@pducolin pducolin pducolin approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chouetz @hush-hush @pducolin @amenasria @AliDatadog