Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2628] Update golang.org/x/net to v33 #32380

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

louis-cqrl
Copy link
Contributor

What does this PR do?

This PR updates golang.org/x/net package to v33

Motivation

We have tagged version v0.33.0 of golang.org/x/net in order to address a security issue.
Version v0.33.0 of golang.org/x/net fixes a vulnerability in the golang.org/x/net/html package which could cause a denial of service.

An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing.
This is CVE-2024-45338 and Go issue https://go.dev/issue/70906.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@louis-cqrl louis-cqrl added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 19, 2024
@louis-cqrl louis-cqrl added this to the 7.62.0 milestone Dec 19, 2024
@louis-cqrl louis-cqrl requested a review from a team as a code owner December 19, 2024 08:06
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Dec 19, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 19, 2024

Uncompressed package size comparison

Comparison with ancestor 52f0517517169d661a94895a296c73b85424c86d

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.06MB ⚠️ 943.06MB 943.00MB 140.00MB
datadog-agent-x86_64-rpm 0.05MB ⚠️ 1197.05MB 1197.00MB 140.00MB
datadog-agent-x86_64-suse 0.05MB ⚠️ 1197.05MB 1197.00MB 140.00MB
datadog-heroku-agent-amd64-deb 0.05MB ⚠️ 505.10MB 505.06MB 70.00MB
datadog-agent-arm64-deb 0.04MB ⚠️ 933.82MB 933.78MB 140.00MB
datadog-agent-amd64-deb 0.02MB ⚠️ 1187.79MB 1187.76MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.79MB 55.79MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm -0.00MB 108.85MB 108.85MB 10.00MB

Decision

⚠️ Warning

@louis-cqrl louis-cqrl changed the title Update golang.org/x/net to v33 [ASCII-2628] Update golang.org/x/net to v33 Dec 19, 2024
@louis-cqrl
Copy link
Contributor Author

/merge

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ca791cf9-5339-4045-8236-678f791bbb8c

Baseline: 52f0517
Comparison: a8b9382
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +1.17 [+0.44, +1.89] 1 Logs
file_tree memory utilization +0.90 [+0.76, +1.04] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.44 [-0.02, +0.90] 1 Logs
quality_gate_idle memory utilization +0.31 [+0.27, +0.36] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.28 [+0.16, +0.40] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.12 [-0.61, +0.84] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.69, +0.88] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.08 [-0.74, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.87, +0.93] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.08, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.00 [-0.77, +0.77] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.69, +0.67] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.91, +0.89] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.61] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.20 [-0.26, -0.15] 1 Logs
quality_gate_logs % cpu utilization -1.96 [-4.90, +0.98] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-19 10:25:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2024-12-19 11:02:36 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 22022a5 into main Dec 19, 2024
397 of 402 checks passed
@dd-mergequeue dd-mergequeue bot deleted the louis-cqrl/update-golang.org/x/net branch December 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants