Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] look directly for the 0 id cgroup when reading /proc #32362

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added component/system-probe team/agent-security short review PR is simple enough to be reviewed quickly labels Dec 18, 2024
@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51507554 --os-family=ubuntu

Note: This applies to commit 863ea1a

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 18, 2024

Uncompressed package size comparison

Comparison with ancestor a2eda15d0208e92ed2288b0efcd05808bb23236c

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.79MB 55.79MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.07MB 505.07MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.32MB 113.32MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.39MB 113.39MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.39MB 113.39MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.79MB 108.79MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.85MB 108.85MB 10.00MB
datadog-agent-amd64-deb -0.01MB 1187.90MB 1187.91MB 140.00MB
datadog-agent-x86_64-rpm -0.01MB 1197.14MB 1197.15MB 140.00MB
datadog-agent-x86_64-suse -0.01MB 1197.14MB 1197.15MB 140.00MB
datadog-agent-aarch64-rpm -0.02MB 943.10MB 943.12MB 140.00MB
datadog-agent-arm64-deb -0.02MB 933.88MB 933.90MB 140.00MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Dec 18, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 163f7916-342e-40da-9c00-835cf5e2b680

Baseline: a2eda15
Comparison: 863ea1a
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization -25.43 [-25.55, -25.32] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.73 [+1.05, +2.42] 1 Logs
quality_gate_idle memory utilization +0.23 [+0.20, +0.27] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.64, +0.93] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.13 [-0.51, +0.77] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.11 [-0.70, +0.93] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.70, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.87, +0.95] 1 Logs
otel_to_otel_logs ingress throughput +0.01 [-0.66, +0.68] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.11, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.51, +0.42] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.08 [-0.92, +0.75] 1 Logs
quality_gate_logs % cpu utilization -0.13 [-3.36, +3.11] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.15 [-1.07, +0.77] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.54 [-1.60, -1.48] 1 Logs
quality_gate_idle_all_features memory utilization -4.62 [-4.71, -4.52] 1 Logs bounds checks dashboard
file_tree memory utilization -25.43 [-25.55, -25.32] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

@paulcacheux paulcacheux force-pushed the paulcacheux/cgroup-direct-id0 branch from 08bb893 to f045e44 Compare December 18, 2024 21:02
@paulcacheux paulcacheux force-pushed the paulcacheux/cgroup-direct-id0 branch from f045e44 to 863ea1a Compare December 18, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant