fix(installer): Make policy metadata files root-owned & world-readable

[BaptisteFoy]

What does this PR do?

Fixes a bug at installer install: we try to write the policy metadata files as dd-agent before having created the dd-agent user.
This PR makes the file owned by root instead, and world-readable so that the daemon can read it. There is no sensitive data in this file anyway.

Motivation

Describe how you validated your changes

Tested manually on a VM + E2E tests

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51475987 --os-family=ubuntu

Note: This applies to commit bcd19da

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 8949577ed72baea2dd7697db60ad37b838d3999e

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1187.76MB	1187.76MB	140.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1197.00MB	1197.00MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1197.00MB	1197.00MB	140.00MB
datadog-agent-arm64-deb	0.00MB	✅	933.77MB	933.77MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	942.99MB	942.99MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.59MB	78.59MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.67MB	78.67MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.67MB	78.67MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.79MB	55.79MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	505.06MB	505.06MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.31MB	113.31MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.38MB	113.38MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.38MB	113.38MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.78MB	108.78MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.85MB	108.85MB	10.00MB

Decision

✅ Passed

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: adc9ee2c-fc3f-4eeb-8553-875edb15b656

Baseline: 8949577
Comparison: bcd19da
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+2.27	[+2.15, +2.40]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.63	[+0.50, +0.76]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.49	[-0.23, +1.21]	1	Logs
➖	quality_gate_idle	memory utilization	+0.44	[+0.39, +0.49]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.40	[-0.38, +1.18]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.16	[-0.30, +0.62]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.09	[-0.69, +0.87]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.06	[-0.81, +0.92]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.04	[-0.59, +0.66]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.83, +0.89]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.00	[-0.90, +0.91]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.11, +0.11]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.68, +0.65]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.47	[-0.53, -0.41]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-1.04	[-1.71, -0.36]	1	Logs
➖	quality_gate_logs	% cpu utilization	-4.06	[-6.96, -1.17]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[BaptisteFoy]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-19 08:02:17 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.

---

2024-12-19 08:38:23 UTC ℹ️ MergeQueue: This merge request was merged