Harden Windows System Probe named pipe #32354
Open
+135
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem, Admnistrators, and ddagentuser.
github-actions
bot
added
component/system-probe
team/windows-kernel-integrations
medium review
alexn-dd
added
the
qa/done
janine-c
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR hardens the Windows system probe named pipe
\\.\pipe\dd_system_probeto be restricted to:Motivation
This enhances the security posture of system probe.
This prevents Information Disclosure and Denial attacks by unprivileged and unauthorized users/processes.
Describe how you validated your changes
CI
inv pipeline.run --here
Manually setup Active Directory environment and gSMA user, verified named pipe connections from agent with gSMA user to system probe.
Manually ran agent commands with agent and system probe as Windows services: status, check cpu, config, configcheck, diagnose, health, hostname, launch-gui, restart-service, stop-service, start-service, flare
Manually queried system probe with NamedPipeCmd.exe, running as Administrator.
Verified named pipe connection fails when a client tool (NamedPipeCmd.exe) is run as an unprivileged user.
Manually step through debugger to check on named pipe creation and named pipe client connections.
Possible Drawbacks / Trade-offs
Some customers may potentially use custom users or custom tools to access the system probe named pipe. These will potentially break and are officially not supported.
Additional Notes
No impact/changes to Linux and other platforms.
See https://docs.google.com/document/d/14itu-TqM_RlCLxnbxeD_h_MRuDYIvo6W/edit