-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USM debugger #32325
Add USM debugger #32325
Conversation
It does not need VMs so do not make it look for them.
A minimal, self-contained build of USM for faster iterations of debugging eBPF code on remote machines. See the README for usage instructions.
[Fast Unit Tests Report] On pipeline 51459797 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51459797 --os-family=ubuntu Note: This applies to commit 9668b8f |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
A minimal, self-contained build of USM for faster iterations of debugging eBPF | ||
code on remote machines. | ||
|
||
Prepare the build for the target architectures you need (the `foo` KMT stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a comment here that you need this for the eBPF object files, specially with cross-arch builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 48763aa Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.44 | [+1.38, +1.49] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +0.90 | [-2.09, +3.89] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.22 | [+0.17, +0.26] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.15 | [-0.33, +0.62] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.06 | [-0.75, +0.87] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.61, +0.65] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.87, +0.87] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.13, +0.09] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.76, +0.71] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.03 | [-0.87, +0.80] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.19 | [-0.96, +0.58] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.21 | [-0.99, +0.58] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.23 | [-0.96, +0.51] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.45 | [-1.17, +0.28] | 1 | Logs |
➖ | file_tree | memory utilization | -0.79 | [-0.93, -0.65] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -1.78 | [-1.90, -1.66] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | quality_gate_logs | memory_usage | 9/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Co-authored-by: Guillermo Julián <[email protected]>
/merge |
Devflow running:
|
What does this PR do?
Adds a minimal, self-contained build of USM for faster iterations of debugging eBPF code on remote machines. See the README for usage instructions.
Motivation
To make development and testing easier.
Describe how you validated your changes
Manual build using instructions and run of binary on some staging hosts.
Possible Drawbacks / Trade-offs
Additional Notes