Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ASCII-2587] Migrating TraceAgent to use IPC cert" #32320

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Dec 18, 2024

Reverts #31847

#incident-33344

This PR has broken new-e2e-agent-shared-components tests in main: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/743239227

@alopezz alopezz requested review from a team as code owners December 18, 2024 08:13
@alopezz alopezz requested a review from ogaca-dd December 18, 2024 08:13
@github-actions github-actions bot added team/agent-apm trace-agent long review PR is complex, plan time to review it labels Dec 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51410391 --os-family=ubuntu

Note: This applies to commit fa72eca

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 9f73ec4f6622e92c48f9008b7797ef5aeb9dc28f

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.02MB ⚠️ 933.77MB 933.76MB 140.00MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 942.99MB 942.97MB 140.00MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1196.99MB 1196.98MB 140.00MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1196.99MB 1196.98MB 140.00MB
datadog-agent-amd64-deb 0.01MB ⚠️ 1187.75MB 1187.74MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ⚠️ 108.84MB 108.84MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.78MB 55.78MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.77MB 108.77MB 10.00MB
datadog-heroku-agent-amd64-deb -0.00MB 505.04MB 505.04MB 70.00MB
datadog-iot-agent-amd64-deb -0.00MB 113.30MB 113.30MB 10.00MB
datadog-iot-agent-x86_64-rpm -0.00MB 113.37MB 113.37MB 10.00MB
datadog-iot-agent-x86_64-suse -0.00MB 113.37MB 113.37MB 10.00MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d91857c1-8003-4676-93eb-04a00e86e612

Baseline: 9f73ec4
Comparison: fa72eca
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +1.01 [+0.97, +1.06] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.88 [+0.76, +1.01] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.36 [-0.33, +1.06] 1 Logs
quality_gate_logs % cpu utilization +0.24 [-2.68, +3.17] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.10 [-0.65, +0.86] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.68, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.85, +0.89] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.86, +0.87] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.02 [-0.49, +0.46] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.98, +0.93] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.68, +0.58] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.80, +0.70] 1 Logs
file_tree memory utilization -0.08 [-0.21, +0.05] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.56 [-0.62, -0.51] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.68 [-1.40, +0.05] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 8/10
file_to_blackhole_100ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@alopezz alopezz added the qa/done QA done before merge and regressions are covered by tests label Dec 18, 2024
@alopezz alopezz merged commit 6d0ce2d into main Dec 18, 2024
233 of 248 checks passed
@alopezz alopezz deleted the revert-31847-misteriaud/ASCII-2587-migrating-trace-agent-to-use-IPC-cert branch December 18, 2024 09:13
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 18, 2024
misteriaud added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants