Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #32312

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test #32312

wants to merge 1 commit into from

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Dec 17, 2024

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@L3n41c L3n41c added do-not-merge/WIP team/containers changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 17, 2024
@L3n41c L3n41c added this to the 7.63.0 milestone Dec 17, 2024
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels Dec 17, 2024
Copy link

cit-pr-commenter bot commented Dec 17, 2024

Go Package Import Differences

Baseline: 593c137
Comparison: 4286022

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
heroku-process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
security-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
security-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
system-probelinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
system-probelinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
heroku-trace-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker

Copy link

cit-pr-commenter bot commented Dec 17, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fde1a78a-3196-4c4f-a045-9a57326a1ca8

Baseline: 593c137
Comparison: 4286022
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization -17.43 [-17.55, -17.32] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -22.00 [-22.06, -21.94] 1 Logs bounds checks dashboard
file_tree memory utilization -23.52 [-23.65, -23.39] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.91 [+0.84, +0.98] 1 Logs
quality_gate_logs % cpu utilization +0.22 [-2.74, +3.17] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.06 [-0.79, +0.91] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.58, +0.68] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.80, +0.89] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.63, +0.68] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.74, +0.80] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.81, +0.85] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.34 [-0.80, +0.12] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.80 [-1.58, -0.03] 1 Logs
otel_to_otel_logs ingress throughput -1.76 [-2.48, -1.03] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.87 [-2.58, -1.15] 1 Logs
quality_gate_idle_all_features memory utilization -17.43 [-17.55, -17.32] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -22.00 [-22.06, -21.94] 1 Logs bounds checks dashboard
file_tree memory utilization -23.52 [-23.65, -23.39] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@L3n41c L3n41c force-pushed the lenaic/rss branch 3 times, most recently from 7eea4fb to b1329ae Compare December 17, 2024 22:52
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Uncompressed package size comparison

Comparison with ancestor 593c137a1db537f340ffb990c7d30386d7bec289

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.03MB ⚠️ 933.81MB 933.78MB 140.00MB
datadog-agent-aarch64-rpm 0.03MB ⚠️ 943.03MB 943.00MB 140.00MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 505.06MB 505.05MB 70.00MB
datadog-agent-amd64-deb 0.01MB ⚠️ 1187.78MB 1187.77MB 140.00MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1197.02MB 1197.01MB 140.00MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1197.02MB 1197.01MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.78MB 55.78MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.84MB 108.84MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51470742 --os-family=ubuntu

Note: This applies to commit 4286022

@L3n41c L3n41c force-pushed the lenaic/rss branch 4 times, most recently from 599de27 to 741144d Compare December 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe do-not-merge/WIP medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant