remove unused choco related files #32310
Merged
+47
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
long review
Gitlab CI Configuration ChangesModified Jobsstages (configuration) stages:
- .pre
- setup
- maintenance_jobs
- deps_build
- deps_fetch
- lint
- source_test
- source_test_stats
- software_composition_analysis
- binary_build
- package_deps_build
- kernel_matrix_testing_prepare
- kernel_matrix_testing_system_probe
- kernel_matrix_testing_security_agent
- kernel_matrix_testing_cleanup
- integration_test
- benchmarks
- package_build
- packaging
- pkg_metrics
- container_build
- container_scan
- check_deploy
- dev_container_deploy
- deploy_containers
- deploy_packages
- deploy_cws_instrumentation
- deploy_dca
- choco_and_install_script_build
- trigger_release
- - choco_and_install_script_deploy
? ----------
+ - install_script_deploy
- internal_image_deploy
- e2e_deploy
- install_script_testing
- e2e_pre_test
- e2e_init
- e2e
- e2e_cleanup
- e2e_k8s
- e2e_install_packages
- functional_test
- junit_upload
- internal_kubernetes_deploy
- post_rc_build
- check_merge
- notify
- .postpowershell_script_deploy powershell_script_deploy:
image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- powershell_script_signing
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
when: manual
script:
- ls $WINDOWS_POWERSHELL_DIR
- $S3_CP_CMD $WINDOWS_POWERSHELL_DIR/Install-Datadog.ps1 s3://dd-agent-mstesting/Install-Datadog.ps1
--grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=3a6e02b08553fd157ae3fb918945dd1eaae5a1aa818940381ef07a430cf25732
- stage: choco_and_install_script_deploy
? ----------
+ stage: install_script_deploy
tags:
- arch:amd64windows_bootstrapper_deploy windows_bootstrapper_deploy:
image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- windows-installer-amd64
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
when: manual
script:
- ls $OMNIBUS_PACKAGE_DIR
- $S3_CP_CMD $OMNIBUS_PACKAGE_DIR/datadog-installer-*-1-x86_64.exe s3://dd-agent-mstesting/datadog-installer-x86_64.exe
--grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=3a6e02b08553fd157ae3fb918945dd1eaae5a1aa818940381ef07a430cf25732
- stage: choco_and_install_script_deploy
? ----------
+ stage: install_script_deploy
tags:
- arch:amd64Added Jobs.windows_choco_7_x64.windows_choco_7_x64:
artifacts:
expire_in: 2 weeks
paths:
- omnibus/pkg
retry: 2
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
if: $BUCKET_BRANCH != "beta" && $BUCKET_BRANCH != "stable"
when: manual
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
script:
- $_instance_id = (iwr -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
; Write-Host "Running on instance $($_instance_id)"
- $ErrorActionPreference = "Stop"
- if (Test-Path build-out) { remove-item -recurse -force build-out }
- 'docker run --rm -v "$(Get-Location):c:\mnt" -e CI_PROJECT_NAME=${CI_PROJECT_NAME}
-e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e BUCKET_BRANCH="$BUCKET_BRANCH" -e AWS_NETWORKING=true
registry.ddbuild.io/ci/datadog-agent-buildimages/windows_1809_${ARCH}${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
powershell.exe -C "C:\mnt\tasks\winbuildscripts\Generate-Chocolatey-Package.ps1
-MSIDirectory c:\mnt\omnibus\pkg -Flavor $FLAVOR -InstallDeps 1"
'
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
- $CopyNupkgToS3 = "$S3_CP_CMD --recursive --exclude '*' --include '*.nupkg' build-out
$S3_RELEASE_ARTIFACTS_URI/choco/nupkg"
- Invoke-Expression $CopyNupkgToS3
stage: choco_and_install_script_build
tags:
- runner:windows-docker
- windowsversion:1809
variables:
ARCH: x64windows_choco_7_x64windows_choco_7_x64:
artifacts:
expire_in: 2 weeks
paths:
- omnibus/pkg
needs:
- windows_msi_and_bosh_zip_x64-a7
retry: 2
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
if: $BUCKET_BRANCH != "beta" && $BUCKET_BRANCH != "stable"
when: manual
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
script:
- $_instance_id = (iwr -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
; Write-Host "Running on instance $($_instance_id)"
- $ErrorActionPreference = "Stop"
- if (Test-Path build-out) { remove-item -recurse -force build-out }
- 'docker run --rm -v "$(Get-Location):c:\mnt" -e CI_PROJECT_NAME=${CI_PROJECT_NAME}
-e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e BUCKET_BRANCH="$BUCKET_BRANCH" -e AWS_NETWORKING=true
registry.ddbuild.io/ci/datadog-agent-buildimages/windows_1809_${ARCH}${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
powershell.exe -C "C:\mnt\tasks\winbuildscripts\Generate-Chocolatey-Package.ps1
-MSIDirectory c:\mnt\omnibus\pkg -Flavor $FLAVOR -InstallDeps 1"
'
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
- $CopyNupkgToS3 = "$S3_CP_CMD --recursive --exclude '*' --include '*.nupkg' build-out
$S3_RELEASE_ARTIFACTS_URI/choco/nupkg"
- Invoke-Expression $CopyNupkgToS3
stage: choco_and_install_script_build
tags:
- runner:windows-docker
- windowsversion:1809
variables:
ARCH: x64
FLAVOR: datadog-agentwindows_choco_7_x64-fipswindows_choco_7_x64-fips:
artifacts:
expire_in: 2 weeks
paths:
- omnibus/pkg
needs:
- windows_msi_and_bosh_zip_x64-a7-fips
retry: 2
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
if: $BUCKET_BRANCH != "beta" && $BUCKET_BRANCH != "stable"
when: manual
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
script:
- $_instance_id = (iwr -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
; Write-Host "Running on instance $($_instance_id)"
- $ErrorActionPreference = "Stop"
- if (Test-Path build-out) { remove-item -recurse -force build-out }
- 'docker run --rm -v "$(Get-Location):c:\mnt" -e CI_PROJECT_NAME=${CI_PROJECT_NAME}
-e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e BUCKET_BRANCH="$BUCKET_BRANCH" -e AWS_NETWORKING=true
registry.ddbuild.io/ci/datadog-agent-buildimages/windows_1809_${ARCH}${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
powershell.exe -C "C:\mnt\tasks\winbuildscripts\Generate-Chocolatey-Package.ps1
-MSIDirectory c:\mnt\omnibus\pkg -Flavor $FLAVOR -InstallDeps 1"
'
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
- $CopyNupkgToS3 = "$S3_CP_CMD --recursive --exclude '*' --include '*.nupkg' build-out
$S3_RELEASE_ARTIFACTS_URI/choco/nupkg"
- Invoke-Expression $CopyNupkgToS3
stage: choco_and_install_script_build
tags:
- runner:windows-docker
- windowsversion:1809
variables:
ARCH: x64
FLAVOR: datadog-fips-agentRemoved Jobs
Changes Summary
ℹ️ Diff available in the job log. |
|
[Fast Unit Tests Report] On pipeline 51503054 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 898efd4 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +0.71 | [-2.22, +3.63] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.43 | [+0.36, +0.50] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.38 | [-0.34, +1.11] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.30 | [-0.16, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.24 | [-0.51, +0.99] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.71, +0.88] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.06 | [-0.70, +0.82] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.86, +0.94] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.02 | [-0.87, +0.91] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.09, +0.11] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.01 | [-0.88, +0.87] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.04 | [-0.67, +0.59] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.11 | [-0.15, -0.07] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.57 | [-0.69, -0.46] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.97 | [-1.08, -0.86] | 1 | Logs bounds checks dashboard |
| ➖ | otel_to_otel_logs | ingress throughput | -0.98 | [-1.65, -0.31] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_0ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
sabrina-datadog
force-pushed
the
sabrina/cleanup-choco
branch
from
7a90dba to
33a2c58
Compare
sabrina-datadog
force-pushed
the
sabrina/cleanup-choco
branch
from
33a2c58 to
da1698d
Compare
CelianR
approved these changes
Dec 18, 2024
julien-lebot
approved these changes
Dec 18, 2024
FlorentClarret
approved these changes
Dec 18, 2024
sabrina-datadog
force-pushed
the
sabrina/cleanup-choco
branch
from
98b28c2 to
04139de
Compare
|
/merge |
Devflow running:
|
sabrina-datadog
added
qa/no-code-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the unused chocolatey jobs:
Rename and reorganize the file structure without "online" since there is no more offline.
Motivation
After chocolatey has been automated, there is no need for the manual components. (BARX-684)
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes