Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Update release.json and Go modules for 7.60.1-rc.1 #32296

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

chouquette
Copy link
Contributor

No description provided.

@chouquette chouquette requested a review from a team as a code owner December 17, 2024 13:46
@chouquette chouquette added this to the 7.60.1 milestone Dec 17, 2024
@chouquette chouquette requested review from a team as code owners December 17, 2024 13:46
@chouquette chouquette requested a review from a team as a code owner December 17, 2024 13:46
@chouquette chouquette requested a review from a team as a code owner December 17, 2024 13:46
@chouquette chouquette added qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Dec 17, 2024
@chouquette chouquette requested review from a team as code owners December 17, 2024 13:46
@chouquette chouquette requested review from songy23 and louis-cqrl and removed request for a team December 17, 2024 13:46
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Dec 17, 2024
@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 17, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-17 13:51:38 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 7.60.x is 39m.


2024-12-17 14:25:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit afd9fad into 7.60.x Dec 17, 2024
248 of 304 checks passed
@dd-mergequeue dd-mergequeue bot deleted the release/7.60.1-rc.1-1734443076 branch December 17, 2024 14:25
@github-actions github-actions bot modified the milestones: 7.60.1, 7.60.0 Dec 17, 2024
Copy link

cit-pr-commenter bot commented Dec 17, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: bebb7587-0be7-400b-ac1b-6410e68648cf

Baseline: afd9fad
Comparison: afd9fad
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -7.48 [-11.19, -3.78] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +3.03 [-0.54, +6.60] 1 Logs
quality_gate_idle_all_features memory utilization +1.40 [+1.30, +1.50] 1 Logs bounds checks dashboard
idle_all_features memory utilization +1.11 [+1.02, +1.21] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.45 [-0.05, +0.95] 1 Logs
idle memory utilization +0.25 [+0.20, +0.29] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.10 [-0.64, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.29, +0.38] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.24, +0.21] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.29, +0.21] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.23, +0.13] 1 Logs
quality_gate_idle memory utilization -0.31 [-0.35, -0.26] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.41 [-1.21, +0.40] 1 Logs
file_tree memory utilization -0.54 [-0.67, -0.41] 1 Logs
tcp_syslog_to_blackhole ingress throughput -3.80 [-4.03, -3.57] 1 Logs
basic_py_check % cpu utilization -7.48 [-11.19, -3.78] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants