Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): [agent6] Remove unecessary jobs #32157

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Dec 13, 2024

What does this PR do?

Remove some unnecessary non-generated jobs from the deploy_dca stage as I suspect they are causing the trigger_release jobs to be skipped on the Agent 6 RC pipeline (see example)
image

Looking on the pipeline configuration, the rule is not preventing this to run

Waiting until the 6.53.1-rc.3 tag appears in Gitlab
Creating RC pipeline
Creating pipeline for datadog-agent on branch/tag 6.53.1-rc.3 with args:
  - DEPLOY_AGENT: true
  - RUN_ALL_BUILDS: true
  - RUN_E2E_TESTS: on
  - RUN_KMT_TESTS: on
  - RELEASE_VERSION_6: release-a6
  - RELEASE_VERSION_7: release-a7
  - BUCKET_BRANCH: beta
  - RC_BUILD: true

so I think it could come from these jobs not launched and required because there is no explicit needs on these jobs.
image

Motivation

Automatic generation of the job is better than running it manually

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested review from a team as code owners December 13, 2024 14:44
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=51080452 --os-family=ubuntu

@chouetz chouetz merged commit 57cbcf8 into 6.53.x Dec 13, 2024
127 of 132 checks passed
@chouetz chouetz deleted the nschweitzer/trigger_release branch December 13, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants