fix(build_rc): Enable compatibility with agent6 #32100
Conversation
chouetz
added
changelog/no-changelog
qa/no-code-change
github-actions
bot
added
the
short review
|
[Fast Unit Tests Report] On pipeline 51068605 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 021ff67 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.76 | [+1.60, +1.93] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.81 | [-2.13, +3.76] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.81 | [+0.16, +1.46] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.26 | [+0.16, +0.36] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.23 | [-0.24, +0.70] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.06 | [-0.57, +0.70] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.03 | [-0.07, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.76, +0.79] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.83, +0.83] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.04 | [-0.90, +0.82] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.05 | [-0.88, +0.77] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.06 | [-0.85, +0.72] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.08 | [-0.85, +0.68] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.24 | [-0.97, +0.48] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.28 | [-0.32, -0.23] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.44 | [-0.57, -0.32] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 8/10 | |
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
tasks/pipeline.py
Outdated
| @@ -43,7 +43,7 @@ | |||
| # Tasks to trigger pipelines | |||
|
|
|||
|
|
|||
| def check_deploy_pipeline(repo: Project, git_ref: str, release_version_6, release_version_7, repo_branch): | |||
| def check_deploy_pipeline(repo_branch): | |||
| """ | |||
| Run checks to verify a deploy pipeline is valid: | |||
| - it targets a valid repo branch | |||
There was a problem hiding this comment.
❓ question
Should you update this description as git_ref is gone?
github-actions
bot
added
medium review
|
/merge |
Devflow running:
|
|
/merge |
Devflow running:
|
What does this PR do?
Motivation
I wanted to validate I could trigger an
agent6pipeline from the main branch ofdatadog-agentusing theinv release.build-rc -r 6.53.xcommandDescribe how you validated your changes
Launched the command from a brand new clone of
datadog-agent. If finally generated this pipelinePossible Drawbacks / Trade-offs
Additional Notes