Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 4.4.0 to 4.4.3 #32041

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2024

Bumps actions/upload-artifact from 4.4.0 to 4.4.3.

Release notes

Sourced from actions/upload-artifact's releases.

v4.4.3

What's Changed

Full Changelog: actions/upload-artifact@v4.4.2...v4.4.3

v4.4.2

What's Changed

Full Changelog: actions/upload-artifact@v4.4.1...v4.4.2

v4.4.1

What's Changed

New Contributors

Full Changelog: actions/upload-artifact@v4.4.0...v4.4.1

Commits
  • b4b15b8 Merge pull request #632 from actions/joshmgross/undo-dependency-changes
  • 92b01eb Undo indirect dependency updates from #627
  • 8448086 Merge pull request #627 from actions/robherley/v4.4.2
  • b1d4642 add explicit relative and absolute symlinks to workflow
  • d50e660 bump version
  • aabe6f8 build with @​actions/artifact v2.1.11
  • 604373d Merge pull request #625 from actions/robherley/artifact-2.1.10
  • 0150148 paste right core version
  • a009b25 update licenses
  • 9f6f6f4 update @​actions/core and @​actions/artifact to latest versions
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@5076954...b4b15b8)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dev/tooling qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Dec 11, 2024
@dependabot dependabot bot requested review from a team as code owners December 11, 2024 16:38
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 11, 2024

The following labels could not be found: dependencies-github-actions.

@github-actions github-actions bot added the medium review PR review might take time label Dec 11, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024

[Fast Unit Tests Report]

On pipeline 51352384 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 56658fee3937e50cae033381d308c96880b91faa

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1271.61MB 1271.61MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.29MB 113.29MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.41MB 78.41MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 526.65MB 526.65MB 70.00MB
datadog-agent-x86_64-rpm 0.00MB 1280.85MB 1280.85MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1280.85MB 1280.85MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.35MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.49MB 78.49MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.49MB 78.49MB 10.00MB
datadog-agent-arm64-deb 0.00MB 1005.67MB 1005.67MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.76MB 108.76MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.64MB 55.64MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB 1014.89MB 1014.89MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.83MB 108.83MB 10.00MB

Decision

✅ Passed

@chouetz
Copy link
Member

chouetz commented Dec 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 16:24:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-13 20:24:54 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@chouetz
Copy link
Member

chouetz commented Dec 17, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 17, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-17 17:13:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-17 18:07:18 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 29m.


2024-12-17 18:31:28 UTC ℹ️ MergeQueue: This merge request was merged

Copy link
Contributor

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 381a3cb and f0a3c1d.

tl;dr

Use these benchmarks as an insight tool during development.

  1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

  2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats
goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            86.38µ ± 1%   88.30µ ± 2%  +2.23% (p=0.000 n=10)
api-gateway-kong-appsec.json                       67.59µ ± 2%   68.93µ ± 1%       ~ (p=0.052 n=10)
api-gateway-kong.json                              64.38µ ± 0%   67.08µ ± 1%  +4.20% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   102.3µ ± 1%   107.7µ ± 2%  +5.30% (p=0.000 n=10)
api-gateway-non-proxy.json                         100.9µ ± 2%   108.6µ ± 1%  +7.63% (p=0.000 n=10)
api-gateway-websocket-connect.json                 65.40µ ± 1%   70.30µ ± 2%  +7.49% (p=0.000 n=10)
api-gateway-websocket-default.json                 58.99µ ± 2%   62.56µ ± 1%  +6.06% (p=0.000 n=10)
api-gateway-websocket-disconnect.json              58.62µ ± 1%   61.55µ ± 1%  +5.00% (p=0.000 n=10)
api-gateway.json                                   108.6µ ± 1%   111.6µ ± 2%  +2.74% (p=0.001 n=10)
application-load-balancer.json                     58.52µ ± 1%   60.35µ ± 1%  +3.13% (p=0.000 n=10)
cloudfront.json                                    44.79µ ± 2%   45.65µ ± 2%       ~ (p=0.052 n=10)
cloudwatch-events.json                             37.36µ ± 1%   38.75µ ± 1%  +3.74% (p=0.000 n=10)
cloudwatch-logs.json                               62.10µ ± 1%   63.96µ ± 4%  +3.00% (p=0.000 n=10)
custom.json                                        31.68µ ± 1%   32.37µ ± 2%  +2.17% (p=0.001 n=10)
dynamodb.json                                      87.27µ ± 2%   88.57µ ± 2%  +1.48% (p=0.002 n=10)
empty.json                                         29.93µ ± 3%   30.99µ ± 1%  +3.53% (p=0.004 n=10)
eventbridge-custom.json                            46.62µ ± 1%   48.13µ ± 5%  +3.25% (p=0.000 n=10)
eventbridge-no-bus.json                            45.21µ ± 1%   46.14µ ± 2%  +2.07% (p=0.007 n=10)
eventbridge-no-timestamp.json                      44.94µ ± 2%   46.50µ ± 2%  +3.48% (p=0.000 n=10)
eventbridgesns.json                                59.34µ ± 1%   60.78µ ± 2%  +2.44% (p=0.000 n=10)
eventbridgesqs.json                                65.98µ ± 1%   66.68µ ± 1%  +1.06% (p=0.002 n=10)
http-api.json                                      65.56µ ± 1%   66.45µ ± 1%  +1.35% (p=0.019 n=10)
kinesis-batch.json                                 64.98µ ± 1%   67.40µ ± 1%  +3.73% (p=0.000 n=10)
kinesis.json                                       52.08µ ± 1%   54.04µ ± 2%  +3.76% (p=0.000 n=10)
s3.json                                            55.98µ ± 1%   57.91µ ± 1%  +3.45% (p=0.000 n=10)
sns-batch.json                                     83.36µ ± 1%   85.57µ ± 1%  +2.65% (p=0.000 n=10)
sns.json                                           63.41µ ± 2%   64.66µ ± 1%  +1.97% (p=0.011 n=10)
snssqs.json                                        106.0µ ± 1%   108.6µ ± 1%  +2.45% (p=0.000 n=10)
snssqs_no_dd_context.json                          96.95µ ± 1%   98.76µ ± 3%  +1.87% (p=0.002 n=10)
sqs-aws-header.json                                54.04µ ± 2%   54.60µ ± 2%       ~ (p=0.143 n=10)
sqs-batch.json                                     87.69µ ± 1%   87.61µ ± 2%       ~ (p=0.781 n=10)
sqs.json                                           64.45µ ± 1%   65.38µ ± 1%  +1.44% (p=0.029 n=10)
sqs_no_dd_context.json                             58.30µ ± 0%   59.40µ ± 1%  +1.90% (p=0.001 n=10)
stepfunction.json                                  41.10µ ± 0%   42.16µ ± 2%  +2.60% (p=0.000 n=10)
geomean                                            62.01µ        63.86µ       +2.99%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.26Ki ± 0%   37.26Ki ± 0%       ~ (p=0.807 n=10)
api-gateway-kong-appsec.json                      26.90Ki ± 0%   26.90Ki ± 0%       ~ (p=0.667 n=10)
api-gateway-kong.json                             24.37Ki ± 0%   24.37Ki ± 0%       ~ (p=0.641 n=10)
api-gateway-non-proxy-async.json                  47.93Ki ± 0%   47.94Ki ± 0%       ~ (p=0.383 n=10)
api-gateway-non-proxy.json                        47.12Ki ± 0%   47.11Ki ± 0%       ~ (p=0.753 n=10)
api-gateway-websocket-connect.json                25.34Ki ± 0%   25.34Ki ± 0%       ~ (p=0.725 n=10)
api-gateway-websocket-default.json                21.23Ki ± 0%   21.23Ki ± 0%       ~ (p=0.815 n=10)
api-gateway-websocket-disconnect.json             20.99Ki ± 0%   20.99Ki ± 0%       ~ (p=0.693 n=10)
api-gateway.json                                  49.27Ki ± 0%   49.26Ki ± 0%       ~ (p=0.382 n=10)
application-load-balancer.json                    22.45Ki ± 0%   22.45Ki ± 0%       ~ (p=0.736 n=10)
cloudfront.json                                   17.43Ki ± 0%   17.44Ki ± 0%       ~ (p=0.292 n=10)
cloudwatch-events.json                            11.49Ki ± 0%   11.49Ki ± 0%       ~ (p=0.958 n=10)
cloudwatch-logs.json                              53.05Ki ± 0%   53.05Ki ± 0%       ~ (p=0.355 n=10)
custom.json                                       9.528Ki ± 0%   9.528Ki ± 0%       ~ (p=0.116 n=10)
dynamodb.json                                     40.30Ki ± 0%   40.30Ki ± 0%       ~ (p=0.115 n=10)
empty.json                                        9.067Ki ± 0%   9.067Ki ± 0%       ~ (p=0.563 n=10)
eventbridge-custom.json                           14.67Ki ± 0%   14.67Ki ± 0%       ~ (p=0.622 n=10)
eventbridge-no-bus.json                           13.63Ki ± 0%   13.63Ki ± 0%       ~ (p=0.101 n=10)
eventbridge-no-timestamp.json                     13.63Ki ± 0%   13.63Ki ± 0%       ~ (p=0.539 n=10)
eventbridgesns.json                               20.43Ki ± 0%   20.43Ki ± 0%       ~ (p=0.136 n=10)
eventbridgesqs.json                               24.56Ki ± 0%   24.56Ki ± 0%  -0.01% (p=0.003 n=10)
http-api.json                                     23.25Ki ± 0%   23.25Ki ± 0%       ~ (p=0.667 n=10)
kinesis-batch.json                                26.49Ki ± 0%   26.49Ki ± 0%       ~ (p=0.194 n=10)
kinesis.json                                      17.37Ki ± 0%   17.37Ki ± 0%       ~ (p=0.487 n=10)
s3.json                                           19.87Ki ± 0%   19.87Ki ± 0%       ~ (p=0.113 n=10)
sns-batch.json                                    39.07Ki ± 0%   39.07Ki ± 0%       ~ (p=0.995 n=10)
sns.json                                          24.49Ki ± 0%   24.49Ki ± 0%       ~ (p=0.454 n=10)
snssqs.json                                       52.68Ki ± 0%   52.68Ki ± 0%       ~ (p=0.059 n=10)
snssqs_no_dd_context.json                         46.44Ki ± 0%   46.44Ki ± 0%       ~ (p=0.353 n=10)
sqs-aws-header.json                               18.79Ki ± 0%   18.79Ki ± 0%       ~ (p=0.590 n=10)
sqs-batch.json                                    41.26Ki ± 0%   41.26Ki ± 0%       ~ (p=0.651 n=10)
sqs.json                                          25.39Ki ± 0%   25.39Ki ± 0%       ~ (p=0.136 n=10)
sqs_no_dd_context.json                            21.01Ki ± 0%   21.01Ki ± 0%  +0.00% (p=0.044 n=10)
stepfunction.json                                 13.50Ki ± 0%   13.51Ki ± 0%       ~ (p=0.720 n=10)
geomean                                           24.10Ki        24.10Ki       -0.00%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             630.0 ± 0%   630.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    723.0 ± 0%   723.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy.json                          713.0 ± 0%   713.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-connect.json                  451.0 ± 0%   451.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  376.0 ± 0%   376.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               366.0 ± 0%   366.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway.json                                    785.0 ± 0%   785.0 ± 0%       ~ (p=1.000 n=10) ¹
application-load-balancer.json                      350.0 ± 0%   350.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudfront.json                                     281.0 ± 0%   281.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-events.json                              218.0 ± 0%   218.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-logs.json                                211.0 ± 0%   211.0 ± 0%       ~ (p=1.000 n=10) ¹
custom.json                                         166.0 ± 0%   166.0 ± 0%       ~ (p=1.000 n=10) ¹
dynamodb.json                                       582.0 ± 0%   582.0 ± 0%       ~ (p=1.000 n=10) ¹
empty.json                                          157.0 ± 0%   157.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-custom.json                             261.0 ± 0%   261.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-bus.json                             252.0 ± 0%   252.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-timestamp.json                       252.0 ± 0%   252.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesns.json                                 318.0 ± 0%   318.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesqs.json                                 358.0 ± 0%   358.0 ± 0%       ~ (p=1.000 n=10) ¹
http-api.json                                       424.0 ± 0%   424.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis-batch.json                                  383.0 ± 0%   383.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis.json                                        279.0 ± 0%   279.0 ± 0%       ~ (p=1.000 n=10) ¹
s3.json                                             351.0 ± 0%   351.0 ± 0%       ~ (p=1.000 n=10) ¹
sns-batch.json                                      465.0 ± 0%   465.0 ± 0%       ~ (p=1.000 n=10) ¹
sns.json                                            336.0 ± 0%   336.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs.json                                         460.0 ± 0%   460.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs_no_dd_context.json                           420.0 ± 0%   420.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-aws-header.json                                 276.0 ± 0%   276.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-batch.json                                      500.0 ± 0%   500.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs.json                                            351.0 ± 0%   351.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs_no_dd_context.json                              337.0 ± 0%   337.0 ± 0%       ~ (p=1.000 n=10) ¹
stepfunction.json                                   226.0 ± 0%   226.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                             360.1        360.1       +0.00%
¹ all samples are equal

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 381a3cb19124c62dccb064ea35c326b26bc3077f

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1187.77MB 1187.77MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1197.01MB 1197.01MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1197.01MB 1197.01MB 140.00MB
datadog-agent-arm64-deb 0.00MB 933.78MB 933.78MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 943.00MB 943.00MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.58MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.78MB 55.78MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.05MB 505.05MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.84MB 108.84MB 10.00MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 41e82b81-f01b-4188-94e3-40ee8fdec17e

Baseline: 381a3cb
Comparison: 3fa75ea
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.75 [-1.20, +4.69] 1 Logs
otel_to_otel_logs ingress throughput +0.74 [+0.08, +1.40] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.34, +0.47] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.24 [-0.22, +0.70] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.19 [-0.69, +1.07] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.18 [-0.59, +0.95] 1 Logs
quality_gate_idle memory utilization +0.10 [+0.05, +0.14] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.77, +0.85] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.09, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.86, +0.87] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.72, +0.71] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.68, +0.58] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.24 [-0.97, +0.49] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.50 [-1.26, +0.27] 1 Logs
file_tree memory utilization -0.94 [-1.08, -0.81] 1 Logs
quality_gate_idle_all_features memory utilization -1.32 [-1.46, -1.18] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit a582565 into main Dec 17, 2024
226 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot/github_actions/actions/upload-artifact-4.4.3 branch December 17, 2024 18:31
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dev/tooling medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants