-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/setup-go from 5.0.2 to 5.2.0 #32037
base: main
Are you sure you want to change the base?
Conversation
The following labels could not be found: |
6e1ffd8
to
68b553e
Compare
[Fast Unit Tests Report] On pipeline 51504708 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
68b553e
to
bed5f25
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 8949577 ❌ Experiments with missing or malformed dataThis is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.
Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.47 | [-0.31, +1.26] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.27 | [-0.45, +1.00] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.13 | [-0.62, +0.89] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.06 | [-0.86, +0.99] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.03 | [-0.04, +0.09] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.89, +0.92] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.02] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.00 | [-0.89, +0.88] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.10, +0.07] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.66, +0.60] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.13 | [-0.90, +0.64] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.41 | [-0.87, +0.05] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.59 | [-0.65, -0.53] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.60 | [-1.32, +0.12] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -1.18 | [-4.13, +1.77] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -2.40 | [-2.53, -2.27] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | quality_gate_idle | memory_usage | 6/10 | bounds checks dashboard |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 6/10 replicas passed. Failed 4 which is > 0. Gate FAILED.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ASC-owned files
bed5f25
to
77557f4
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
/merge |
Devflow running:
|
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@0a12ed9...3041bf5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
77557f4
to
d07c256
Compare
/merge |
Devflow running:
|
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats
|
Bumps actions/setup-go from 5.0.2 to 5.2.0.
Release notes
Sourced from actions/setup-go's releases.
Commits
3041bf5
feat: fallback to "raw" endpoint for manifest when rate limit is reached (#496)41dfa10
Enhance workflows and Upgrade micromatch Dependency (#510)9419772
ReviseisGhes
logic (#511)d60b41a
Merge pull request #502 from actions/Jcambass-patch-1e09f57f
Upgrade IA Publishdf1a117
Merge pull request #500 from actions/Jcambass-patch-149582f6
Add workflow file for publishing releases to immutable action packageb26d402
fix: add arch to cache key (#493)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)