Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usm: telemetry: tests: Move Clear method to test only file #31981

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

guyarb
Copy link
Contributor

@guyarb guyarb commented Dec 10, 2024

What does this PR do?

The Clear method is used only in tests, therefore moving it to a testutil file to ensure no inappropriate usage is being done with it

Motivation

Ensuring no usage of test utils in production code

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

The Clear method is used only in tests, therefore moving it to a testutil file
to ensure no inappropriate usage is being done with it
@guyarb guyarb added changelog/no-changelog team/usm The USM team qa/no-code-change No code change in Agent code requiring validation labels Dec 10, 2024
@guyarb guyarb requested a review from a team as a code owner December 10, 2024 19:07
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor ea648f38c679860629c00e9ccc465fcb4593279c

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -1.40MB 1271.29MB 1272.69MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb -1.40MB 526.45MB 527.85MB 70.00MB
datadog-agent-x86_64-rpm -1.41MB 1280.52MB 1281.93MB 140.00MB
datadog-agent-x86_64-suse -1.41MB 1280.52MB 1281.93MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.26MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.26MB 113.26MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.00MB ⚠️ 1005.44MB 1005.44MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.67MB 108.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB ⚠️ 1014.66MB 1014.66MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.74MB 108.74MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50752378 --os-family=ubuntu

Note: This applies to commit 8167525

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 01859b59-a770-4a98-a192-9dadda50cf00

Baseline: ea648f3
Comparison: 8167525
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.18 [-1.76, +4.12] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.17 [+1.11, +1.24] 1 Logs
quality_gate_idle_all_features memory utilization +0.85 [+0.74, +0.96] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.81 [+0.07, +1.54] 1 Logs
quality_gate_idle memory utilization +0.20 [+0.16, +0.24] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.20 [-0.57, +0.97] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.79, +0.96] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.73, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.82, +0.85] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.89, +0.90] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.62] 1 Logs
otel_to_otel_logs ingress throughput -0.06 [-0.77, +0.64] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.78, +0.65] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.11 [-0.56, +0.34] 1 Logs
file_tree memory utilization -0.66 [-0.77, -0.54] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_100ms_latency lost_bytes 8/10
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@guyarb
Copy link
Contributor Author

guyarb commented Dec 10, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 10, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-10 20:30:25 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 8a450cc into main Dec 10, 2024
332 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guy.arbitman/move-utility branch December 10, 2024 20:53
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants